You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/11 18:01:49 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request #3960: Rename
max.retries setting
nvazquez opened a new pull request #3960: Rename max.retries setting
URL: https://github.com/apache/cloudstack/pull/3960
## Description
Simply rename a global setting name to a more descriptive one:
`max.retries` to `vm.ha.migration.max.retries`
Also, as it is used in global context, have changed the scope from Cluster to Global.
This setting has been introduced before 4.14, so no need to update DB on upgrade
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3960: Rename
max.retries setting
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3960: Rename max.retries setting
URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-597783287
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3960: Rename
max.retries setting
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3960: Rename max.retries setting
URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-598605034
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3960: Rename max.retries
setting
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3960: Rename max.retries setting
URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-597783008
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3960: Rename
max.retries setting
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3960: Rename max.retries setting
URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-598868020
2 x LGTMS, test results passing,
merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3960: Rename
max.retries setting
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3960: Rename max.retries setting
URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-597794289
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1041
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3960: Rename
max.retries setting
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3960: Rename max.retries setting
URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-597785259
LGTM
the setting did not exist previously, so nothing to handle in the upgrade path SQL files...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3960: Rename
max.retries setting
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3960: Rename max.retries setting
URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-598862080
<b>Trillian test result (tid-1240)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35656 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3960-t1240-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3960: Rename max.retries
setting
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3960: Rename max.retries setting
URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-598230436
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3960: Rename
max.retries setting
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3960: Rename max.retries setting
URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-598693420
Will probably wait for tests to complete before the code freeze, unless you are 100% sure @shwstppr that we can proceed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3960: Rename
max.retries setting
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3960: Rename max.retries setting
URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-598604672
just checking if the kubernetes error is persistent.
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3960: Rename
max.retries setting
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3960: Rename max.retries setting
URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-598511853
<b>Trillian test result (tid-1236)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38758 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3960-t1236-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 1059.84 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb merged pull request #3960: Rename
max.retries setting
Posted by GitBox <gi...@apache.org>.
andrijapanicsb merged pull request #3960: Rename max.retries setting
URL: https://github.com/apache/cloudstack/pull/3960
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3960: Rename
max.retries setting
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3960: Rename max.retries setting
URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-598230978
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3960: Rename
max.retries setting
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3960: Rename max.retries setting
URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-598860816
Tests are complete from the previous run where shwstppr (author of the failing test) has confirmed it's not realted to this PR.
Nevertheless, new tests.
This PR is allowed to be merged after the currently running tests complete (in sense of the code freeze fof 4.14)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services