You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/10 20:03:12 UTC
[GitHub] [druid] maytasm commented on a change in pull request #10354: Integration tests and docs for auto compaction with different partitioning
maytasm commented on a change in pull request #10354:
URL: https://github.com/apache/druid/pull/10354#discussion_r486595931
##########
File path: .travis.yml
##########
@@ -417,11 +417,19 @@ jobs:
script: *run_integration_test
after_failure: *integration_test_diags
+ - &integration_auto_compaction_tests
+ name: "(Compile=openjdk8, Run=openjdk8) auto compaction integration test"
+ jdk: openjdk8
+ services: *integration_test_services
+ env: TESTNG_GROUPS='-Dgroups=other-index' JVM_RUNTIME='-Djvm.runtime=8'
Review comment:
Should be rename the TestNGGroup from "other-index" to "compact"? AFAIK, the "other-index" only has auto-compaction IT and manual compaction IT. If we do that then we can rename this job from "integration_auto_compaction_tests" to "integration_compaction_tests". My concern is with the job saying auto_compaction but the test group is other-index which in the future may contains non compaction related tests
##########
File path: .travis.yml
##########
@@ -417,11 +417,19 @@ jobs:
script: *run_integration_test
after_failure: *integration_test_diags
+ - &integration_auto_compaction_tests
+ name: "(Compile=openjdk8, Run=openjdk8) auto compaction integration test"
+ jdk: openjdk8
+ services: *integration_test_services
+ env: TESTNG_GROUPS='-Dgroups=other-index' JVM_RUNTIME='-Djvm.runtime=8'
+ script: *run_integration_test
+ after_failure: *integration_test_diags
+
- &integration_tests
name: "(Compile=openjdk8, Run=openjdk8) other integration test"
jdk: openjdk8
services: *integration_test_services
- env: TESTNG_GROUPS='-DexcludedGroups=batch-index,input-format,input-source,perfect-rollup-parallel-batch-index,kafka-index,query,query-retry,realtime-index,security,s3-deep-storage,gcs-deep-storage,azure-deep-storage,hdfs-deep-storage,s3-ingestion,kinesis-index,kinesis-data-format,kafka-transactional-index,kafka-index-slow,kafka-transactional-index-slow,kafka-data-format,hadoop-s3-to-s3-deep-storage,hadoop-s3-to-hdfs-deep-storage,hadoop-azure-to-azure-deep-storage,hadoop-azure-to-hdfs-deep-storage,hadoop-gcs-to-gcs-deep-storage,hadoop-gcs-to-hdfs-deep-storage,aliyun-oss-deep-storage,append-ingestion' JVM_RUNTIME='-Djvm.runtime=11'
+ env: TESTNG_GROUPS='-DexcludedGroups=batch-index,input-format,input-source,perfect-rollup-parallel-batch-index,kafka-index,query,query-retry,realtime-index,security,s3-deep-storage,gcs-deep-storage,azure-deep-storage,hdfs-deep-storage,s3-ingestion,kinesis-index,kinesis-data-format,kafka-transactional-index,kafka-index-slow,kafka-transactional-index-slow,kafka-data-format,hadoop-s3-to-s3-deep-storage,hadoop-s3-to-hdfs-deep-storage,hadoop-azure-to-azure-deep-storage,hadoop-azure-to-hdfs-deep-storage,hadoop-gcs-to-gcs-deep-storage,hadoop-gcs-to-hdfs-deep-storage,aliyun-oss-deep-storage,append-ingestion,other-index' JVM_RUNTIME='-Djvm.runtime=11'
Review comment:
Doesn't have to be address but maybe we should get rid of this. This is only running a single test since we move out the "other-index"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org