You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-user@hadoop.apache.org by Jim Donofrio <do...@gmail.com> on 2013/02/07 14:40:24 UTC

why does OldCombinerRunner pass Reporter.NULL to the combiner instead of the real reporter?

Is there a good reason why the OldCombinerRunner passes Reporter.NULL to 
the combiner instead of the actual TaskReporter? The NewCombinerRunner 
does use the TaskReporter when creating the context. If this is a bug I 
will submit a JIRA with a patch

Re: why does OldCombinerRunner pass Reporter.NULL to the combiner instead of the real reporter?

Posted by Jim Donofrio <do...@gmail.com>.
I submitted MAPREDUCE-4998 with a patch

On 02/07/2013 11:18 AM, Harsh J wrote:
> I agree its a bug if there is a discrepancy between the APIs (we are
> supposed to be supporting both for the time being). Please do file a
> JIRA with a patch - there shouldn't be any harm in re-passing the
> reporter object within the combiner.
>
> On Thu, Feb 7, 2013 at 7:10 PM, Jim Donofrio <do...@gmail.com> wrote:
>> Is there a good reason why the OldCombinerRunner passes Reporter.NULL to the
>> combiner instead of the actual TaskReporter? The NewCombinerRunner does use
>> the TaskReporter when creating the context. If this is a bug I will submit a
>> JIRA with a patch
>
>
> --
> Harsh J
>


Re: why does OldCombinerRunner pass Reporter.NULL to the combiner instead of the real reporter?

Posted by Jim Donofrio <do...@gmail.com>.
I submitted MAPREDUCE-4998 with a patch

On 02/07/2013 11:18 AM, Harsh J wrote:
> I agree its a bug if there is a discrepancy between the APIs (we are
> supposed to be supporting both for the time being). Please do file a
> JIRA with a patch - there shouldn't be any harm in re-passing the
> reporter object within the combiner.
>
> On Thu, Feb 7, 2013 at 7:10 PM, Jim Donofrio <do...@gmail.com> wrote:
>> Is there a good reason why the OldCombinerRunner passes Reporter.NULL to the
>> combiner instead of the actual TaskReporter? The NewCombinerRunner does use
>> the TaskReporter when creating the context. If this is a bug I will submit a
>> JIRA with a patch
>
>
> --
> Harsh J
>


Re: why does OldCombinerRunner pass Reporter.NULL to the combiner instead of the real reporter?

Posted by Jim Donofrio <do...@gmail.com>.
I submitted MAPREDUCE-4998 with a patch

On 02/07/2013 11:18 AM, Harsh J wrote:
> I agree its a bug if there is a discrepancy between the APIs (we are
> supposed to be supporting both for the time being). Please do file a
> JIRA with a patch - there shouldn't be any harm in re-passing the
> reporter object within the combiner.
>
> On Thu, Feb 7, 2013 at 7:10 PM, Jim Donofrio <do...@gmail.com> wrote:
>> Is there a good reason why the OldCombinerRunner passes Reporter.NULL to the
>> combiner instead of the actual TaskReporter? The NewCombinerRunner does use
>> the TaskReporter when creating the context. If this is a bug I will submit a
>> JIRA with a patch
>
>
> --
> Harsh J
>


Re: why does OldCombinerRunner pass Reporter.NULL to the combiner instead of the real reporter?

Posted by Jim Donofrio <do...@gmail.com>.
I submitted MAPREDUCE-4998 with a patch

On 02/07/2013 11:18 AM, Harsh J wrote:
> I agree its a bug if there is a discrepancy between the APIs (we are
> supposed to be supporting both for the time being). Please do file a
> JIRA with a patch - there shouldn't be any harm in re-passing the
> reporter object within the combiner.
>
> On Thu, Feb 7, 2013 at 7:10 PM, Jim Donofrio <do...@gmail.com> wrote:
>> Is there a good reason why the OldCombinerRunner passes Reporter.NULL to the
>> combiner instead of the actual TaskReporter? The NewCombinerRunner does use
>> the TaskReporter when creating the context. If this is a bug I will submit a
>> JIRA with a patch
>
>
> --
> Harsh J
>


Re: why does OldCombinerRunner pass Reporter.NULL to the combiner instead of the real reporter?

Posted by Harsh J <ha...@cloudera.com>.
I agree its a bug if there is a discrepancy between the APIs (we are
supposed to be supporting both for the time being). Please do file a
JIRA with a patch - there shouldn't be any harm in re-passing the
reporter object within the combiner.

On Thu, Feb 7, 2013 at 7:10 PM, Jim Donofrio <do...@gmail.com> wrote:
> Is there a good reason why the OldCombinerRunner passes Reporter.NULL to the
> combiner instead of the actual TaskReporter? The NewCombinerRunner does use
> the TaskReporter when creating the context. If this is a bug I will submit a
> JIRA with a patch



--
Harsh J

Re: why does OldCombinerRunner pass Reporter.NULL to the combiner instead of the real reporter?

Posted by Harsh J <ha...@cloudera.com>.
I agree its a bug if there is a discrepancy between the APIs (we are
supposed to be supporting both for the time being). Please do file a
JIRA with a patch - there shouldn't be any harm in re-passing the
reporter object within the combiner.

On Thu, Feb 7, 2013 at 7:10 PM, Jim Donofrio <do...@gmail.com> wrote:
> Is there a good reason why the OldCombinerRunner passes Reporter.NULL to the
> combiner instead of the actual TaskReporter? The NewCombinerRunner does use
> the TaskReporter when creating the context. If this is a bug I will submit a
> JIRA with a patch



--
Harsh J

Re: why does OldCombinerRunner pass Reporter.NULL to the combiner instead of the real reporter?

Posted by Harsh J <ha...@cloudera.com>.
I agree its a bug if there is a discrepancy between the APIs (we are
supposed to be supporting both for the time being). Please do file a
JIRA with a patch - there shouldn't be any harm in re-passing the
reporter object within the combiner.

On Thu, Feb 7, 2013 at 7:10 PM, Jim Donofrio <do...@gmail.com> wrote:
> Is there a good reason why the OldCombinerRunner passes Reporter.NULL to the
> combiner instead of the actual TaskReporter? The NewCombinerRunner does use
> the TaskReporter when creating the context. If this is a bug I will submit a
> JIRA with a patch



--
Harsh J

Re: why does OldCombinerRunner pass Reporter.NULL to the combiner instead of the real reporter?

Posted by Harsh J <ha...@cloudera.com>.
I agree its a bug if there is a discrepancy between the APIs (we are
supposed to be supporting both for the time being). Please do file a
JIRA with a patch - there shouldn't be any harm in re-passing the
reporter object within the combiner.

On Thu, Feb 7, 2013 at 7:10 PM, Jim Donofrio <do...@gmail.com> wrote:
> Is there a good reason why the OldCombinerRunner passes Reporter.NULL to the
> combiner instead of the actual TaskReporter? The NewCombinerRunner does use
> the TaskReporter when creating the context. If this is a bug I will submit a
> JIRA with a patch



--
Harsh J