You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/15 17:51:23 UTC

[GitHub] [arrow] westonpace commented on pull request #8922: ARROW-10852 [C++] AssertTablesEqual(verbose=true) segfaults if the le…

westonpace commented on pull request #8922:
URL: https://github.com/apache/arrow/pull/8922#issuecomment-745457881


   https://issues.apache.org/jira/browse/ARROW-10922
   
   > This looks good to me.
   > 
   > The proper solution would be to extend `Diff` with support for chunked arrays. Currently a diff between `[1, 2], [4, 5, 6]` and `[1, 2], [3, 4, 5, 6]` will simply report the different lengths rather than showing the diff, which would be fairly meanginful in this case. Additionally, when requiring chunk layouts to be equal the diffs can be very messy since it proceeds chunkwise. This need not be addressed in this PR, but please add a follow up JIRA
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org