You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "JingsongLi (via GitHub)" <gi...@apache.org> on 2023/03/24 03:36:50 UTC
[GitHub] [incubator-paimon] JingsongLi opened a new issue, #705: [Bug] LogStoreTableFactory should not implements DynamicTableFactory
JingsongLi opened a new issue, #705:
URL: https://github.com/apache/incubator-paimon/issues/705
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/incubator-paimon/issues) and found nothing similar.
### Paimon version
0.4
### Compute Engine
flink
### Minimal reproduce step
kafka connector sink to paimon table
### What doesn't meet your expectations?
Now, KafkaLogStoreFactory is very easy to conflict with flink kafka connector.
we should not use flink DynamicTableFactory.
### Anything else?
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi closed issue #705: [Bug] LogStoreTableFactory should not implements DynamicTableFactory
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi closed issue #705: [Bug] LogStoreTableFactory should not implements DynamicTableFactory
URL: https://github.com/apache/incubator-paimon/issues/705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] SteNicholas closed issue #705: [Bug] LogStoreTableFactory should not implements DynamicTableFactory
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed issue #705: [Bug] LogStoreTableFactory should not implements DynamicTableFactory
URL: https://github.com/apache/incubator-paimon/issues/705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] SteNicholas commented on issue #705: [Bug] LogStoreTableFactory should not implements DynamicTableFactory
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on issue #705:
URL: https://github.com/apache/incubator-paimon/issues/705#issuecomment-1485023969
@Alibaba-HZY, welcome to contribute. Please go ahead to fix the bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] legendtkl commented on issue #705: [Bug] LogStoreTableFactory should not implements DynamicTableFactory
Posted by "legendtkl (via GitHub)" <gi...@apache.org>.
legendtkl commented on issue #705:
URL: https://github.com/apache/incubator-paimon/issues/705#issuecomment-1483732474
@JingsongLi Do you mean when we use kafka connector in the job, it will find LogStoreTableFactory as kafka connector?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on issue #705: [Bug] LogStoreTableFactory should not implements DynamicTableFactory
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on issue #705:
URL: https://github.com/apache/incubator-paimon/issues/705#issuecomment-1487967243
The https://github.com/apache/incubator-paimon/pull/729 is valid.
But we need to go ahead and complete the issue.
The core reason is that if there is no kafka jar in flink/lib, the kafka identifier will find `KafkaLogStoreFactory` in paimon, and throw `KafkaLogStoreFactory is not a DynamicTableSourceFactory` exception, which is very confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] Alibaba-HZY commented on issue #705: [Bug] LogStoreTableFactory should not implements DynamicTableFactory
Posted by "Alibaba-HZY (via GitHub)" <gi...@apache.org>.
Alibaba-HZY commented on issue #705:
URL: https://github.com/apache/incubator-paimon/issues/705#issuecomment-1484983472
i want to do this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] Alibaba-HZY commented on issue #705: [Bug] LogStoreTableFactory should not implements DynamicTableFactory
Posted by "Alibaba-HZY (via GitHub)" <gi...@apache.org>.
Alibaba-HZY commented on issue #705:
URL: https://github.com/apache/incubator-paimon/issues/705#issuecomment-1486516159
we can use flink DynamicTableFactory . the reason for this issue is that flink1.16-connector-kafka dependencies on kafka-clients 3.x, but paimon-flink-common dependencies on kafka-client version is 2.x, which may leads to classloader conflicts or class not found.so we can provided the Kafka-client dependency. When the user needs to use the external log systems or the kafka connector, user needs to add the flink-connetor-kafka connector dependency in the lib directory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] Alibaba-HZY commented on issue #705: [Bug] LogStoreTableFactory should not implements DynamicTableFactory
Posted by "Alibaba-HZY (via GitHub)" <gi...@apache.org>.
Alibaba-HZY commented on issue #705:
URL: https://github.com/apache/incubator-paimon/issues/705#issuecomment-1488025132
> The #729 is valid. But we need to go ahead and complete the issue. The core reason is that if there is no kafka jar in flink/lib, the kafka identifier will find `KafkaLogStoreFactory` in paimon, and throw `KafkaLogStoreFactory is not a DynamicTableSourceFactory` exception, which is very confused.
ok i know i will remove DynamicTableFactory in LogStoreTableFactory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org