You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@toree.apache.org by rdblue <gi...@git.apache.org> on 2017/06/10 19:13:37 UTC
[GitHub] incubator-toree pull request #120: TOREE-412: Update AddDeps magic
GitHub user rdblue opened a pull request:
https://github.com/apache/incubator-toree/pull/120
TOREE-412: Update AddDeps magic
* Removes non-Jar files (POM files) from downloaded artifacts before adding dependencies to the kernel
* Updates to Coursier 1.0.0-M15-7
* Uses "default" configuration by default, instead of "compile" for Ivy dependencies
* Adds `--classifier` for maven artifacts
* Adds `--ivy-configuration` for Ivy artifacts
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rdblue/incubator-toree TOREE-412-update-add-deps
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-toree/pull/120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #120
----
commit 6289e78064c788e3d6c56397abd7278fd067128d
Author: Ryan Blue <bl...@apache.org>
Date: 2017-04-18T21:32:12Z
TOREE-412: Fix AddDeps by removing POM files.
commit 642b2d1463d7d48ae48dfafe262957f071fe63ef
Author: Ryan Blue <bl...@apache.org>
Date: 2017-04-19T20:03:09Z
TOREE-412: Update Coursier to 1.0.0-M15-7.
commit 039b549b6a0af30266f2be429629e7d79dba4fbb
Author: Ryan Blue <bl...@apache.org>
Date: 2017-04-19T21:55:56Z
TOREE-412: Set AddDeps configuration to default.
commit a7d15e4bbcdb4c321d3ce3996487953375e8d254
Author: Ryan Blue <bl...@apache.org>
Date: 2017-04-25T18:37:58Z
TOREE-412: Add --classifier to AddDeps.
commit 8642253b5b694901b9d470c02c210a579cc3827e
Author: Ryan Blue <bl...@apache.org>
Date: 2017-04-25T21:19:48Z
TOREE-412: Add --ivy-configuration option to AddDeps.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-toree pull request #120: TOREE-412: Update AddDeps magic
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-toree/pull/120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---