You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "AyWa (via GitHub)" <gi...@apache.org> on 2023/08/20 05:22:37 UTC

[GitHub] [beam] AyWa opened a new pull request, #28068: add option for artifacts

AyWa opened a new pull request, #28068:
URL: https://github.com/apache/beam/pull/28068

   ## Description
   
   When running the `FlinkPortableClientEntryPoint`, we should be able to pass some arguments that the `JobServerDriver` can handle (because `FlinkPortableClientEntryPoint` is starting the job server driver).
   
   Actually, I can see there is other todo in the JobServer like handle the filesystem arguments ? 
   
   My hope is to make an other PR, that add those filesystem arguments in `FlinkPortableClientEntryPoint` and the `JobServerDriver`
   
   ------------------------
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flink portable client entrypoint should have options for artifacts [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #28068: Flink portable client entrypoint should have options for artifacts
URL: https://github.com/apache/beam/pull/28068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flink portable client entrypoint should have options for artifacts [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1836023475

   Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @Abacn added as fallback since no labels match configuration
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flink portable client entrypoint should have options for artifacts [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1829723045

   Reminder, please take a look at this pr: @Abacn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flink portable client entrypoint should have options for artifacts [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1793427054

   Reminder, please take a look at this pr: @Abacn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flink portable client entrypoint should have options for artifacts [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1783001312

   @AyWa @Abacn what are next steps on this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #28068: Flink portable client entrypoint should have options for artifacts

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1702651983

   Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @Abacn added as fallback since no labels match configuration
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #28068: Flink portable client entrypoint should have options for artifacts

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #28068:
URL: https://github.com/apache/beam/pull/28068#discussion_r1317418819


##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPortableClientEntryPoint.java:
##########
@@ -73,28 +79,41 @@
 public class FlinkPortableClientEntryPoint {
   private static final Logger LOG = LoggerFactory.getLogger(FlinkPortableClientEntryPoint.class);
   private static final String JOB_ENDPOINT_FLAG = "--job_endpoint";
-  private static final Duration JOB_INVOCATION_TIMEOUT = Duration.ofSeconds(30);
-  private static final Duration JOB_SERVICE_STARTUP_TIMEOUT = Duration.ofSeconds(30);
+  // TODO: add environments variable or parameters
+  private static final Duration JOB_INVOCATION_TIMEOUT = Duration.ofSeconds(90);

Review Comment:
   yeah, please, there is no harm to do that - and better keep the default setting as is



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AyWa commented on a diff in pull request #28068: Flink portable client entrypoint should have options for artifacts

Posted by "AyWa (via GitHub)" <gi...@apache.org>.
AyWa commented on code in PR #28068:
URL: https://github.com/apache/beam/pull/28068#discussion_r1314098646


##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPortableClientEntryPoint.java:
##########
@@ -73,28 +79,41 @@
 public class FlinkPortableClientEntryPoint {
   private static final Logger LOG = LoggerFactory.getLogger(FlinkPortableClientEntryPoint.class);
   private static final String JOB_ENDPOINT_FLAG = "--job_endpoint";
-  private static final Duration JOB_INVOCATION_TIMEOUT = Duration.ofSeconds(30);
-  private static final Duration JOB_SERVICE_STARTUP_TIMEOUT = Duration.ofSeconds(30);
+  // TODO: add environments variable or parameters
+  private static final Duration JOB_INVOCATION_TIMEOUT = Duration.ofSeconds(90);
+  private static final Duration JOB_SERVICE_STARTUP_TIMEOUT = Duration.ofSeconds(90);
 
   private final String driverCmd;
+  private final String artifactStagingPath;
+  private final boolean cleanArtifactsPerJob;
   private FlinkJobServerDriver jobServer;
   private Thread jobServerThread;
   private DetachedJobInvokerFactory jobInvokerFactory;
   private int jobPort = 0; // pick any free port
 
-  public FlinkPortableClientEntryPoint(String driverCmd) {
+  public FlinkPortableClientEntryPoint(String driverCmd, String artifactStagingPath,
+                                       boolean cleanArtifactsPerJob) {
     Preconditions.checkState(
         !driverCmd.contains(JOB_ENDPOINT_FLAG),
         "Driver command must not contain " + JOB_ENDPOINT_FLAG);
     this.driverCmd = driverCmd;
+    this.cleanArtifactsPerJob = cleanArtifactsPerJob;
+    this.artifactStagingPath = artifactStagingPath;
   }
 
   /** Main method to be called standalone or by Flink (CLI or REST API). */
   public static void main(String[] args) throws Exception {
+    // TODO: Expose the fileSystem related options.
+    PipelineOptions options = PipelineOptionsFactory.create();
+    // Limiting gcs upload buffer to reduce memory usage while doing parallel artifact uploads.
+    options.as(GcsOptions.class).setGcsUploadBufferSizeBytes(1024 * 1024);

Review Comment:
   > Another concern is that FileSystems.setDefaultPipelineOptions(options) will affect all following behaviors until its getting overwritten. So if there is an approach not affecting global it would be ideal
   
   For now this is the same code as the `JobServerDriver` have. So the code is a bit duplicated, but the behavior should be same



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flink portable client entrypoint should have options for artifacts [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1951308786

   This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flink portable client entrypoint should have options for artifacts [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1852083383

   Hey @AyWa any update here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flink portable client entrypoint should have options for artifacts [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1801771327

   Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @Abacn added as fallback since no labels match configuration
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] gli-marc-hurabielle commented on pull request #28068: add option for artifacts

Posted by "gli-marc-hurabielle (via GitHub)" <gi...@apache.org>.
gli-marc-hurabielle commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1685722388

   Upload to s3 is working, but then I have other issue, that might be related to this change, still investigating


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #28068: Flink portable client entrypoint should have options for artifacts

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #28068:
URL: https://github.com/apache/beam/pull/28068#discussion_r1308983078


##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPortableClientEntryPoint.java:
##########
@@ -73,28 +79,41 @@
 public class FlinkPortableClientEntryPoint {
   private static final Logger LOG = LoggerFactory.getLogger(FlinkPortableClientEntryPoint.class);
   private static final String JOB_ENDPOINT_FLAG = "--job_endpoint";
-  private static final Duration JOB_INVOCATION_TIMEOUT = Duration.ofSeconds(30);
-  private static final Duration JOB_SERVICE_STARTUP_TIMEOUT = Duration.ofSeconds(30);
+  // TODO: add environments variable or parameters
+  private static final Duration JOB_INVOCATION_TIMEOUT = Duration.ofSeconds(90);
+  private static final Duration JOB_SERVICE_STARTUP_TIMEOUT = Duration.ofSeconds(90);
 
   private final String driverCmd;
+  private final String artifactStagingPath;
+  private final boolean cleanArtifactsPerJob;
   private FlinkJobServerDriver jobServer;
   private Thread jobServerThread;
   private DetachedJobInvokerFactory jobInvokerFactory;
   private int jobPort = 0; // pick any free port
 
-  public FlinkPortableClientEntryPoint(String driverCmd) {
+  public FlinkPortableClientEntryPoint(String driverCmd, String artifactStagingPath,

Review Comment:
   as the parameter propagates we might need a Builder for this class, avoid keep adding parameter to constructor



##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPortableClientEntryPoint.java:
##########
@@ -73,28 +79,41 @@
 public class FlinkPortableClientEntryPoint {
   private static final Logger LOG = LoggerFactory.getLogger(FlinkPortableClientEntryPoint.class);
   private static final String JOB_ENDPOINT_FLAG = "--job_endpoint";
-  private static final Duration JOB_INVOCATION_TIMEOUT = Duration.ofSeconds(30);
-  private static final Duration JOB_SERVICE_STARTUP_TIMEOUT = Duration.ofSeconds(30);
+  // TODO: add environments variable or parameters
+  private static final Duration JOB_INVOCATION_TIMEOUT = Duration.ofSeconds(90);
+  private static final Duration JOB_SERVICE_STARTUP_TIMEOUT = Duration.ofSeconds(90);
 
   private final String driverCmd;
+  private final String artifactStagingPath;
+  private final boolean cleanArtifactsPerJob;
   private FlinkJobServerDriver jobServer;
   private Thread jobServerThread;
   private DetachedJobInvokerFactory jobInvokerFactory;
   private int jobPort = 0; // pick any free port
 
-  public FlinkPortableClientEntryPoint(String driverCmd) {
+  public FlinkPortableClientEntryPoint(String driverCmd, String artifactStagingPath,
+                                       boolean cleanArtifactsPerJob) {
     Preconditions.checkState(
         !driverCmd.contains(JOB_ENDPOINT_FLAG),
         "Driver command must not contain " + JOB_ENDPOINT_FLAG);
     this.driverCmd = driverCmd;
+    this.cleanArtifactsPerJob = cleanArtifactsPerJob;
+    this.artifactStagingPath = artifactStagingPath;
   }
 
   /** Main method to be called standalone or by Flink (CLI or REST API). */
   public static void main(String[] args) throws Exception {
+    // TODO: Expose the fileSystem related options.
+    PipelineOptions options = PipelineOptionsFactory.create();
+    // Limiting gcs upload buffer to reduce memory usage while doing parallel artifact uploads.
+    options.as(GcsOptions.class).setGcsUploadBufferSizeBytes(1024 * 1024);

Review Comment:
   The default buffer size should not cause issue, unless there are too much upload (~100) happening in parallel. In this case the proper fix should be limiting the parallel upload to a reasonable number.
   
   Another concern is that `FileSystems.setDefaultPipelineOptions(options)` will affect all following behaviors until its getting overwritten. So if there is an approach not affecting global it would be ideal 
   



##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPortableClientEntryPoint.java:
##########
@@ -73,28 +79,41 @@
 public class FlinkPortableClientEntryPoint {
   private static final Logger LOG = LoggerFactory.getLogger(FlinkPortableClientEntryPoint.class);
   private static final String JOB_ENDPOINT_FLAG = "--job_endpoint";
-  private static final Duration JOB_INVOCATION_TIMEOUT = Duration.ofSeconds(30);
-  private static final Duration JOB_SERVICE_STARTUP_TIMEOUT = Duration.ofSeconds(30);
+  // TODO: add environments variable or parameters
+  private static final Duration JOB_INVOCATION_TIMEOUT = Duration.ofSeconds(90);

Review Comment:
   Just curious, was there some hurdle making 30 second timeout not enough got job invocation / job service startup?   If so likely there are something could be optimized



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #28068: Flink portable client entrypoint should have options for artifacts

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1708534150

   waiting on author


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flink portable client entrypoint should have options for artifacts [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1783078369

   > I was quite busy with other work. I will try to cleanup this PR this week!
   
   Thanks, and no problem as long as we know next steps - I just wanted to make sure it wasn't stuck :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AyWa commented on a diff in pull request #28068: Flink portable client entrypoint should have options for artifacts

Posted by "AyWa (via GitHub)" <gi...@apache.org>.
AyWa commented on code in PR #28068:
URL: https://github.com/apache/beam/pull/28068#discussion_r1314098221


##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPortableClientEntryPoint.java:
##########
@@ -73,28 +79,41 @@
 public class FlinkPortableClientEntryPoint {
   private static final Logger LOG = LoggerFactory.getLogger(FlinkPortableClientEntryPoint.class);
   private static final String JOB_ENDPOINT_FLAG = "--job_endpoint";
-  private static final Duration JOB_INVOCATION_TIMEOUT = Duration.ofSeconds(30);
-  private static final Duration JOB_SERVICE_STARTUP_TIMEOUT = Duration.ofSeconds(30);
+  // TODO: add environments variable or parameters
+  private static final Duration JOB_INVOCATION_TIMEOUT = Duration.ofSeconds(90);

Review Comment:
   I had some problem with the 30 second timeout in my test k8s cluster.
   Should I put that in the cli option ? 



##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPortableClientEntryPoint.java:
##########
@@ -73,28 +79,41 @@
 public class FlinkPortableClientEntryPoint {
   private static final Logger LOG = LoggerFactory.getLogger(FlinkPortableClientEntryPoint.class);
   private static final String JOB_ENDPOINT_FLAG = "--job_endpoint";
-  private static final Duration JOB_INVOCATION_TIMEOUT = Duration.ofSeconds(30);
-  private static final Duration JOB_SERVICE_STARTUP_TIMEOUT = Duration.ofSeconds(30);
+  // TODO: add environments variable or parameters
+  private static final Duration JOB_INVOCATION_TIMEOUT = Duration.ofSeconds(90);
+  private static final Duration JOB_SERVICE_STARTUP_TIMEOUT = Duration.ofSeconds(90);
 
   private final String driverCmd;
+  private final String artifactStagingPath;
+  private final boolean cleanArtifactsPerJob;
   private FlinkJobServerDriver jobServer;
   private Thread jobServerThread;
   private DetachedJobInvokerFactory jobInvokerFactory;
   private int jobPort = 0; // pick any free port
 
-  public FlinkPortableClientEntryPoint(String driverCmd) {
+  public FlinkPortableClientEntryPoint(String driverCmd, String artifactStagingPath,

Review Comment:
   okay let me try to do that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #28068: Flink portable client entrypoint should have options for artifacts

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1697325169

   Reminder, please take a look at this pr: @Abacn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flink portable client entrypoint should have options for artifacts [beam]

Posted by "AyWa (via GitHub)" <gi...@apache.org>.
AyWa commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1783013467

   > @AyWa @Abacn what are next steps on this PR?
   
   I was quite busy with other work. I will try to cleanup this PR this week! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flink portable client entrypoint should have options for artifacts [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1812433333

   Reminder, please take a look at this pr: @Abacn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flink portable client entrypoint should have options for artifacts [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1818953832

   Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @Abacn added as fallback since no labels match configuration
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flink portable client entrypoint should have options for artifacts [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1937697432

   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #28068: add option for artifacts

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1685195932

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @Abacn added as fallback since no labels match configuration
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flink portable client entrypoint should have options for artifacts [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28068:
URL: https://github.com/apache/beam/pull/28068#issuecomment-1848393380

   Reminder, please take a look at this pr: @Abacn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org