You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2010/11/05 23:46:42 UTC

[jira] Created: (HBASE-3203) We can get an order to open a region while shutting down and it'll hold up regionserver shutdown

We can get an order to open a region while shutting down and it'll hold up regionserver shutdown
------------------------------------------------------------------------------------------------

                 Key: HBASE-3203
                 URL: https://issues.apache.org/jira/browse/HBASE-3203
             Project: HBase
          Issue Type: Bug
            Reporter: stack
             Fix For: 0.90.0


Starting and stopping clusters I see that an open directive can come in while we are shutting down all the user space regions on a particular regionserver.  Regionservers will only shut themselves down after all user space regions have closed.  We queue up all the closes at a particular time.  If an open comes in while we are in the closing condition, then the regionserver won't go down.  The region open needs to be blocked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-3203) We can get an order to open a region while shutting down and it'll hold up regionserver shutdown

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-3203:
-------------------------

    Attachment: stopping-v2.txt

Add check when splitting too.

> We can get an order to open a region while shutting down and it'll hold up regionserver shutdown
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-3203
>                 URL: https://issues.apache.org/jira/browse/HBASE-3203
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.90.0
>
>         Attachments: stopping-v2.txt, stopping.txt
>
>
> Starting and stopping clusters I see that an open directive can come in while we are shutting down all the user space regions on a particular regionserver.  Regionservers will only shut themselves down after all user space regions have closed.  We queue up all the closes at a particular time.  If an open comes in while we are in the closing condition, then the regionserver won't go down.  The region open needs to be blocked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-3203) We can get an order to open a region while shutting down and it'll hold up regionserver shutdown

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928865#action_12928865 ] 

Jonathan Gray commented on HBASE-3203:
--------------------------------------

looks fine to me.  kind of unfortunate we have new 'stopping' state, but guess we need it because can't just have 'stopped' earlier?  makes sense i suppose.  anything else we want to reject if closing?

good fix on that completely wrong comment :)

+1 to commit if you've done some testing w/ it

> We can get an order to open a region while shutting down and it'll hold up regionserver shutdown
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-3203
>                 URL: https://issues.apache.org/jira/browse/HBASE-3203
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.90.0
>
>         Attachments: stopping-v2.txt, stopping-v3.txt, stopping.txt
>
>
> Starting and stopping clusters I see that an open directive can come in while we are shutting down all the user space regions on a particular regionserver.  Regionservers will only shut themselves down after all user space regions have closed.  We queue up all the closes at a particular time.  If an open comes in while we are in the closing condition, then the regionserver won't go down.  The region open needs to be blocked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-3203) We can get an order to open a region while shutting down and it'll hold up regionserver shutdown

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-3203:
-------------------------

    Attachment: stopping-v3.txt

> We can get an order to open a region while shutting down and it'll hold up regionserver shutdown
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-3203
>                 URL: https://issues.apache.org/jira/browse/HBASE-3203
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.90.0
>
>         Attachments: stopping-v2.txt, stopping-v3.txt, stopping.txt
>
>
> Starting and stopping clusters I see that an open directive can come in while we are shutting down all the user space regions on a particular regionserver.  Regionservers will only shut themselves down after all user space regions have closed.  We queue up all the closes at a particular time.  If an open comes in while we are in the closing condition, then the regionserver won't go down.  The region open needs to be blocked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-3203) We can get an order to open a region while shutting down and it'll hold up regionserver shutdown

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928878#action_12928878 ] 

stack commented on HBASE-3203:
------------------------------

Thanks for the review.

We used to do 'stopping'.  Smile.

'Stopping' gets us closer to classic Lifecycle.

I think just needed for this at mo.

> We can get an order to open a region while shutting down and it'll hold up regionserver shutdown
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-3203
>                 URL: https://issues.apache.org/jira/browse/HBASE-3203
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.90.0
>
>         Attachments: stopping-v2.txt, stopping-v3.txt, stopping.txt
>
>
> Starting and stopping clusters I see that an open directive can come in while we are shutting down all the user space regions on a particular regionserver.  Regionservers will only shut themselves down after all user space regions have closed.  We queue up all the closes at a particular time.  If an open comes in while we are in the closing condition, then the regionserver won't go down.  The region open needs to be blocked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-3203) We can get an order to open a region while shutting down and it'll hold up regionserver shutdown

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-3203:
-------------------------

    Attachment: stopping.txt

> We can get an order to open a region while shutting down and it'll hold up regionserver shutdown
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-3203
>                 URL: https://issues.apache.org/jira/browse/HBASE-3203
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.90.0
>
>         Attachments: stopping.txt
>
>
> Starting and stopping clusters I see that an open directive can come in while we are shutting down all the user space regions on a particular regionserver.  Regionservers will only shut themselves down after all user space regions have closed.  We queue up all the closes at a particular time.  If an open comes in while we are in the closing condition, then the regionserver won't go down.  The region open needs to be blocked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-3203) We can get an order to open a region while shutting down and it'll hold up regionserver shutdown

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-3203.
--------------------------

    Resolution: Fixed

Committed small fix (Been testing up on cluster).

> We can get an order to open a region while shutting down and it'll hold up regionserver shutdown
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-3203
>                 URL: https://issues.apache.org/jira/browse/HBASE-3203
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.90.0
>
>         Attachments: stopping-v2.txt, stopping-v3.txt, stopping.txt
>
>
> Starting and stopping clusters I see that an open directive can come in while we are shutting down all the user space regions on a particular regionserver.  Regionservers will only shut themselves down after all user space regions have closed.  We queue up all the closes at a particular time.  If an open comes in while we are in the closing condition, then the regionserver won't go down.  The region open needs to be blocked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.