You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/02/16 12:30:07 UTC
Review Request 43597: HIVE-13064: Serde properties are not working
while expecting output in a directory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43597/
-----------------------------------------------------------
Review request for hive and Amareshwari Sriramadasu.
Bugs: HIVE-13064
https://issues.apache.org/jira/browse/HIVE-13064
Repository: hive-git
Description
-------
Added handling of serde properties.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8a06582
ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 04d26f3
ql/src/test/results/clientpositive/insert_overwrite_directory.q.out e5d2455
Diff: https://reviews.apache.org/r/43597/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 43597: HIVE-13064: Serde properties are not
working while expecting output in a directory
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43597/#review119866
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Feb. 19, 2016, 9:21 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43597/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 9:21 a.m.)
>
>
> Review request for hive and Amareshwari Sriramadasu.
>
>
> Bugs: HIVE-13064
> https://issues.apache.org/jira/browse/HIVE-13064
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added handling of serde properties.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8a06582
> ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 04d26f3
> ql/src/test/queries/clientpositive/insert_overwrite_directory.q c3d419b
> ql/src/test/results/clientpositive/insert_overwrite_directory.q.out e5d2455
>
> Diff: https://reviews.apache.org/r/43597/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 43597: HIVE-13064: Serde properties are not
working while expecting output in a directory
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43597/
-----------------------------------------------------------
(Updated Feb. 19, 2016, 2:51 p.m.)
Review request for hive and Amareshwari Sriramadasu.
Bugs: HIVE-13064
https://issues.apache.org/jira/browse/HIVE-13064
Repository: hive-git
Description
-------
Added handling of serde properties.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8a06582
ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 04d26f3
ql/src/test/queries/clientpositive/insert_overwrite_directory.q c3d419b
ql/src/test/results/clientpositive/insert_overwrite_directory.q.out e5d2455
Diff: https://reviews.apache.org/r/43597/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 43597: HIVE-13064: Serde properties are not
working while expecting output in a directory
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43597/
-----------------------------------------------------------
(Updated Feb. 19, 2016, 1:09 p.m.)
Review request for hive and Amareshwari Sriramadasu.
Changes
-------
Added collection delim, and also varied field delim as a POC
Bugs: HIVE-13064
https://issues.apache.org/jira/browse/HIVE-13064
Repository: hive-git
Description
-------
Added handling of serde properties.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8a06582
ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 04d26f3
ql/src/test/queries/clientpositive/insert_overwrite_directory.q c3d419b
ql/src/test/results/clientpositive/insert_overwrite_directory.q.out e5d2455
Diff: https://reviews.apache.org/r/43597/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 43597: HIVE-13064: Serde properties are not
working while expecting output in a directory
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43597/#review119298
-----------------------------------------------------------
ql/src/test/results/clientpositive/insert_overwrite_directory.q.out (line 1204)
<https://reviews.apache.org/r/43597/#comment180628>
Can you add colelction.delim (not a typo property has typo) also to the test? and update output accordingly?
ql/src/test/results/clientpositive/insert_overwrite_directory.q.out (line 1241)
<https://reviews.apache.org/r/43597/#comment180629>
Can you add colelction.delim and mapkey.delim also and update output accordingly?
- Amareshwari Sriramadasu
On Feb. 16, 2016, 11:30 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43597/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 11:30 a.m.)
>
>
> Review request for hive and Amareshwari Sriramadasu.
>
>
> Bugs: HIVE-13064
> https://issues.apache.org/jira/browse/HIVE-13064
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added handling of serde properties.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8a06582
> ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 04d26f3
> ql/src/test/results/clientpositive/insert_overwrite_directory.q.out e5d2455
>
> Diff: https://reviews.apache.org/r/43597/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>