Re: [I] Improvement: Allow callers to configure metrics reporter on ScanBuilder [iceberg]

["alexandrefimov (via GitHub)" <gi...@apache.org>]

alexandrefimov commented on issue #14875:
URL: https://github.com/apache/iceberg/issues/14875#issuecomment-4583337588

   Hi, I am interested in picking this up if the direction is still welcome.
   
   From a diagnostics/observability perspective, exposing `metricsReporter` on `IcebergGenerics.ScanBuilder` looks useful because the builder currently hides the underlying `TableScan`, while `TableScan` already supports scan metrics reporting. The change I have in mind is intentionally small: add a delegating `metricsReporter(MetricsReporter reporter)` method to `IcebergGenerics.ScanBuilder`, keep the existing `TableScan.metricsReporter` combine semantics, and cover it with a focused test that verifies a `ScanReport` is emitted for a generic read.
   
   I noticed the earlier PR #14654 was closed as stale rather than rejected. If there are no objections to this API shape, I can send a minimal PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org