You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ashishkumar50 (via GitHub)" <gi...@apache.org> on 2023/04/06 09:05:37 UTC
[GitHub] [ozone] ashishkumar50 commented on a diff in pull request #4531: HDDS-8292. Inconsistent key name handling for FSO bucket files.
ashishkumar50 commented on code in PR #4531:
URL: https://github.com/apache/ozone/pull/4531#discussion_r1159501894
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java:
##########
@@ -444,6 +445,11 @@ private void getCacheValues() {
continue;
}
+ // Copy cache value to local copy and work on it
Review Comment:
Hi @swagle , Thanks for the review. OmDirectoryInfo and OmKeyInfo are only objects used for accessing cache in OzoneListStatusHelper.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java:
##########
@@ -444,6 +445,11 @@ private void getCacheValues() {
continue;
}
+ // Copy cache value to local copy and work on it
+ Value copyOmInfo = ObjectUtils.clone(cacheOmInfo);
Review Comment:
Hi @kerneltime , Thanks for the review. In MinHeapIterator already read bucket locking exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org