You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/27 06:55:17 UTC
[GitHub] [pulsar] devinbost opened a new pull request #10396: [Broker] Preventing extra dispatch when entries will make permits negative
devinbost opened a new pull request #10396:
URL: https://github.com/apache/pulsar/pull/10396
I noticed that the broker currently does not consider the number of entries when determining if it should dispatch messages to the consumer. Due to the missing check, the broker can send more messages than available permits.
This PR prevents that from happening for persistent topics.
Related to #6054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on pull request #10396: [Broker] Preventing extra dispatch when entries will make permits negative
Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #10396:
URL: https://github.com/apache/pulsar/pull/10396#issuecomment-827746542
The reason for this is that we want to avoid having to re-read messages again from storage. The number of permits going to negative is "fine", in the sense that the next round will adjust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] devinbost commented on pull request #10396: [Broker] Preventing extra dispatch when entries will make permits negative
Posted by GitBox <gi...@apache.org>.
devinbost commented on pull request #10396:
URL: https://github.com/apache/pulsar/pull/10396#issuecomment-827923658
I'm closing this because there are a number of areas that expect permits to be <= 0 to control message flow, and this PR doesn't address the root issue behind subscriptions getting stuck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] devinbost commented on pull request #10396: [Broker] Preventing extra dispatch when entries will make permits negative
Posted by GitBox <gi...@apache.org>.
devinbost commented on pull request #10396:
URL: https://github.com/apache/pulsar/pull/10396#issuecomment-827751860
@merlimat If the permits go negative when the subscription is stuck, then the approach by @rdhabalia to unblock the subscription won't work. See https://github.com/rdhabalia/pulsar/blob/df5195475edd2b6938849e7b2e5bc52aabad207d/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java#L587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] devinbost commented on pull request #10396: [Broker] Preventing extra dispatch when entries will make permits negative
Posted by GitBox <gi...@apache.org>.
devinbost commented on pull request #10396:
URL: https://github.com/apache/pulsar/pull/10396#issuecomment-827372941
@rdhabalia @codelipenghui @merlimat @sijie Anything else I should add to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] devinbost closed pull request #10396: [Broker] Preventing extra dispatch when entries will make permits negative
Posted by GitBox <gi...@apache.org>.
devinbost closed pull request #10396:
URL: https://github.com/apache/pulsar/pull/10396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org