You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/20 11:59:09 UTC
[GitHub] [dolphinscheduler] jieguangzhou opened a new pull request, #10175: [Feature][MLops] Add MLflow Projects (custom project) component
jieguangzhou opened a new pull request, #10175:
URL: https://github.com/apache/dolphinscheduler/pull/10175
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
Update MLflow task plugin to enable Dolphin users to schedule [MLflow](https://mlflow.org/).
This PR close: #10174.
Because I want to continue enriching the capabilities of this plugin, leave the issue open for now.
- [x] Custom projects: Support for running your own MLflow projects
<img width="498" alt="image" src="https://user-images.githubusercontent.com/31528124/169523527-23ab747f-82bf-467a-b3cf-54601932171e.png">
## Brief change log
- Support Custom projects for MLflow Projects
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] jieguangzhou commented on a diff in pull request #10175: [Feature][MLops] Add MLflow Projects (custom project) component
Posted by GitBox <gi...@apache.org>.
jieguangzhou commented on code in PR #10175:
URL: https://github.com/apache/dolphinscheduler/pull/10175#discussion_r878976757
##########
docs/docs/en/guide/task/mlflow.md:
##########
@@ -114,6 +110,24 @@ First, introduce some general parameters of DolphinScheduler
and [flaml](https://github.com/microsoft/FLAML)
+#### Custom projects
+
+
+
+**Task Parameter**
+
+- **mlflow server tracking uri** ：MLflow server uri, default http://localhost:5000.
+- **experiment name** ：The experiment in which the task is running, if none, is created.
Review Comment:
I think creating the experiment name automatically is not a good operation in this case. It will add a default value ("Default", same as mlflow) of the experiment name for this component now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng merged pull request #10175: [Feature][MLops] Add MLflow Projects (custom project) component
Posted by GitBox <gi...@apache.org>.
caishunfeng merged PR #10175:
URL: https://github.com/apache/dolphinscheduler/pull/10175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10175: [Feature][MLops] Add MLflow Projects (custom project) component
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10175:
URL: https://github.com/apache/dolphinscheduler/pull/10175#issuecomment-1134135412
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10175)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10175&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10175&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10175: [Feature][MLops] Add MLflow Projects (custom project) component
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10175:
URL: https://github.com/apache/dolphinscheduler/pull/10175#issuecomment-1134120931
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10175)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10175&metric=new_coverage&view=list) [86.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10175&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10175&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10175&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10175: [Feature][MLops] Add MLflow Projects (custom project) component
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10175:
URL: https://github.com/apache/dolphinscheduler/pull/10175#discussion_r878966864
##########
docs/docs/en/guide/task/mlflow.md:
##########
@@ -114,6 +110,24 @@ First, introduce some general parameters of DolphinScheduler
and [flaml](https://github.com/microsoft/FLAML)
+#### Custom projects
+
+
+
+**Task Parameter**
+
+- **mlflow server tracking uri** ：MLflow server uri, default http://localhost:5000.
+- **experiment name** ：The experiment in which the task is running, if none, is created.
Review Comment:
Will experience name be created automatically? If so, i think it's better to use ```The experiment in which the task is running. If it is blank, it will be created automatically.``` So as chinese doc.
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-mlflow/src/test/java/org/apache/dolphinler/plugin/task/mlflow/MlflowTaskTest.java:
##########
@@ -90,6 +90,13 @@ public void testInitAutoMLTask() throws Exception {
String command = mlflowTask.buildCommand();
}
+ @Test
+ public void testInitCustomProjectTask() throws Exception {
+ MlflowTask mlflowTask = initTask(createCustomProjectParameters());
+ String command = mlflowTask.buildCommand();
+ mlflowTask.handle();
Review Comment:
Assert should be used in some of tests to verify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] jieguangzhou commented on a diff in pull request #10175: [Feature][MLops] Add MLflow Projects (custom project) component
Posted by GitBox <gi...@apache.org>.
jieguangzhou commented on code in PR #10175:
URL: https://github.com/apache/dolphinscheduler/pull/10175#discussion_r878984097
##########
docs/docs/en/guide/task/mlflow.md:
##########
@@ -114,6 +110,24 @@ First, introduce some general parameters of DolphinScheduler
and [flaml](https://github.com/microsoft/FLAML)
+#### Custom projects
+
+
+
+**Task Parameter**
+
+- **mlflow server tracking uri** ：MLflow server uri, default http://localhost:5000.
+- **experiment name** ：The experiment in which the task is running, if none, is created.
Review Comment:
I have changed it to "Create the experiment where the task is running, if the experiment does not exist. If the name is empty, it is set to ` Default `, the same as MLflow."
##########
docs/docs/en/guide/task/mlflow.md:
##########
@@ -114,6 +110,24 @@ First, introduce some general parameters of DolphinScheduler
and [flaml](https://github.com/microsoft/FLAML)
+#### Custom projects
+
+
+
+**Task Parameter**
+
+- **mlflow server tracking uri** ：MLflow server uri, default http://localhost:5000.
+- **experiment name** ：The experiment in which the task is running, if none, is created.
Review Comment:
I think creating the experiment name automatically is not a good operation in this case. It will add a default value ("Default", same as mlflow) of the experiment name for this component now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] jieguangzhou commented on a diff in pull request #10175: [Feature][MLops] Add MLflow Projects (custom project) component
Posted by GitBox <gi...@apache.org>.
jieguangzhou commented on code in PR #10175:
URL: https://github.com/apache/dolphinscheduler/pull/10175#discussion_r878984297
##########
docs/docs/en/guide/task/mlflow.md:
##########
@@ -114,6 +110,24 @@ First, introduce some general parameters of DolphinScheduler
and [flaml](https://github.com/microsoft/FLAML)
+#### Custom projects
+
+
+
+**Task Parameter**
+
+- **mlflow server tracking uri** ：MLflow server uri, default http://localhost:5000.
+- **experiment name** ：The experiment in which the task is running, if none, is created.
Review Comment:
Thanks for your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] jieguangzhou commented on a diff in pull request #10175: [Feature][MLops] Add MLflow Projects (custom project) component
Posted by GitBox <gi...@apache.org>.
jieguangzhou commented on code in PR #10175:
URL: https://github.com/apache/dolphinscheduler/pull/10175#discussion_r878973446
##########
docs/docs/en/guide/task/mlflow.md:
##########
@@ -114,6 +110,24 @@ First, introduce some general parameters of DolphinScheduler
and [flaml](https://github.com/microsoft/FLAML)
+#### Custom projects
+
+
+
+**Task Parameter**
+
+- **mlflow server tracking uri** ：MLflow server uri, default http://localhost:5000.
+- **experiment name** ：The experiment in which the task is running, if none, is created.
Review Comment:
The experiment name will not be created automatically. It will be set with "Default" in mlflow if experiment name is blank.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] jieguangzhou commented on a diff in pull request #10175: [Feature][MLops] Add MLflow Projects (custom project) component
Posted by GitBox <gi...@apache.org>.
jieguangzhou commented on code in PR #10175:
URL: https://github.com/apache/dolphinscheduler/pull/10175#discussion_r878976757
##########
docs/docs/en/guide/task/mlflow.md:
##########
@@ -114,6 +110,24 @@ First, introduce some general parameters of DolphinScheduler
and [flaml](https://github.com/microsoft/FLAML)
+#### Custom projects
+
+
+
+**Task Parameter**
+
+- **mlflow server tracking uri** ：MLflow server uri, default http://localhost:5000.
+- **experiment name** ：The experiment in which the task is running, if none, is created.
Review Comment:
I think creating the experiment name automatically is not a good operation in this case. I will add a default value of the experiment name for this component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10175: [Feature][MLops] Add MLflow Projects (custom project) component
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10175:
URL: https://github.com/apache/dolphinscheduler/pull/10175#discussion_r878783307
##########
dolphinscheduler-ui/src/locales/modules/zh_CN.ts:
##########
@@ -2,6 +2,7 @@
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
+ mlflowProjectRepository: '运行仓库',
Review Comment:
Licensed header should not included this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] jieguangzhou commented on a diff in pull request #10175: [Feature][MLops] Add MLflow Projects (custom project) component
Posted by GitBox <gi...@apache.org>.
jieguangzhou commented on code in PR #10175:
URL: https://github.com/apache/dolphinscheduler/pull/10175#discussion_r878953210
##########
dolphinscheduler-ui/src/locales/modules/zh_CN.ts:
##########
@@ -2,6 +2,7 @@
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
+ mlflowProjectRepository: '运行仓库',
Review Comment:
Thanks for reviewing, I have fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] jieguangzhou commented on a diff in pull request #10175: [Feature][MLops] Add MLflow Projects (custom project) component
Posted by GitBox <gi...@apache.org>.
jieguangzhou commented on code in PR #10175:
URL: https://github.com/apache/dolphinscheduler/pull/10175#discussion_r878991665
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-mlflow/src/test/java/org/apache/dolphinler/plugin/task/mlflow/MlflowTaskTest.java:
##########
@@ -90,6 +90,13 @@ public void testInitAutoMLTask() throws Exception {
String command = mlflowTask.buildCommand();
}
+ @Test
+ public void testInitCustomProjectTask() throws Exception {
+ MlflowTask mlflowTask = initTask(createCustomProjectParameters());
+ String command = mlflowTask.buildCommand();
+ mlflowTask.handle();
Review Comment:
Thanks for your suggestions. I have fixed these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #10175: [Feature][MLops] Add MLflow Projects (custom project) component
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10175:
URL: https://github.com/apache/dolphinscheduler/pull/10175#issuecomment-1134043445
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10175?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10175](https://codecov.io/gh/apache/dolphinscheduler/pull/10175?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3a7eb6) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/e11373b963d7a092e1228fdb374fa9aa5aa4b521?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e11373b) will **increase** coverage by `0.04%`.
> The diff coverage is `84.61%`.
```diff
@@ Coverage Diff @@
## dev #10175 +/- ##
============================================
+ Coverage 40.94% 40.98% +0.04%
- Complexity 4731 4737 +6
============================================
Files 854 854
Lines 34552 34565 +13
Branches 3818 3819 +1
============================================
+ Hits 14146 14167 +21
+ Misses 19051 19043 -8
Partials 1355 1355
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/10175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nscheduler/plugin/task/mlflow/MlflowConstants.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10175/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stbWxmbG93L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi90YXNrL21sZmxvdy9NbGZsb3dDb25zdGFudHMuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...olphinscheduler/plugin/task/mlflow/MlflowTask.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10175/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stbWxmbG93L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi90YXNrL21sZmxvdy9NbGZsb3dUYXNrLmphdmE=) | `79.16% <60.00%> (+12.99%)` | :arrow_up: |
| [...scheduler/plugin/task/mlflow/MlflowParameters.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10175/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stbWxmbG93L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi90YXNrL21sZmxvdy9NbGZsb3dQYXJhbWV0ZXJzLmphdmE=) | `66.30% <100.00%> (+3.20%)` | :arrow_up: |
| [...dolphinscheduler/remote/future/ResponseFuture.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10175/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2Z1dHVyZS9SZXNwb25zZUZ1dHVyZS5qYXZh) | `81.96% <0.00%> (-1.64%)` | :arrow_down: |
| [.../dolphinscheduler/common/utils/ParameterUtils.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10175/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1BhcmFtZXRlclV0aWxzLmphdmE=) | `73.13% <0.00%> (+0.40%)` | :arrow_up: |
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10175/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `83.33% <0.00%> (+5.55%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10175?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10175?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e11373b...e3a7eb6](https://codecov.io/gh/apache/dolphinscheduler/pull/10175?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10175: [Feature][MLops] Add MLflow Projects (custom project) component
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10175:
URL: https://github.com/apache/dolphinscheduler/pull/10175#issuecomment-1134047684
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10175)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10175&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10175&metric=new_coverage&view=list) [86.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10175&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10175&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10175&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org