[GitHub] [incubator-pekko] seglo commented on a diff in pull request #105: Publish nightlies to Apache Nexus Repository

[GitBox <gi...@apache.org>]

seglo commented on code in PR #105:
URL: https://github.com/apache/incubator-pekko/pull/105#discussion_r1071589128


##########
.github/workflows/publish-nightly.yml:
##########
@@ -51,6 +51,12 @@ jobs:
         with:
           java-version: adopt@1.11
 
+      - name: Publish to Apache Maven repo
+        env:
+          NEXUS_USER: ${{ secrets.NEXUS_USER }}
+          NEXUS_PW: ${{ secrets.NEXUS_PW }}
+        run: sbt +publish
+

Review Comment:
   I think we should only publish milestone release artifacts to Apache's maven repo, otherwise the nightlies deployment is redundant. Milestone releases should be human-initiated, probably using a release-by-tag pattern like Akka currently does.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org