[GitHub] [arrow] thisisnic commented on a diff in pull request #13174: ARROW-16439: [R] Implement bindings for lubridate's fast_strptime

[GitBox <gi...@apache.org>]

thisisnic commented on code in PR #13174:
URL: https://github.com/apache/arrow/pull/13174#discussion_r875997100


##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -618,4 +618,40 @@ register_bindings_datetime_parsers <- function() {
   for (ymd_order in ymd_parser_vec) {
     register_binding(ymd_order, ymd_parser_map_factory(ymd_order))
   }
+
+  register_binding("fast_strptime", function(x,
+                                             format,
+                                             tz = "UTC",
+                                             lt = FALSE,
+                                             cutoff_2000 = 68L) {
+    # `lt` controls the output `lt = TRUE` returns a POSIXlt (which doesn't play
+    # well with mutate, for example)
+    if (lt) {
+      arrow_not_supported("`lt = TRUE` argument")
+    }

Review Comment:
   Please can you chuck in a test for `lt=TRUE`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org