[GitHub] [arrow] alamb commented on a change in pull request #7924: ARROW-9653: [Rust][DataFusion] Properly handle multi-column aggregates

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #7924:
URL: https://github.com/apache/arrow/pull/7924#discussion_r468000922



##########
File path: rust/datafusion/src/execution/physical_plan/hash_aggregate.rs
##########
@@ -500,50 +500,49 @@ impl RecordBatchReader for GroupedHashAggregateIterator {
                 )),
             };
             result_arrays.push(array.map_err(ExecutionError::into_arrow_external_error)?);
+        }

Review comment:
       If you look at this with a whitespace blind diff: https://github.com/apache/arrow/pull/7924/files?w=1 the change might be easier to see. The issue is that the current code adds the aggregate expressions one per *grouping expression* rather than once per operator. 
   
   The change is in essence, to move the location of the closing `}` for aggregate expressions




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org