[GitHub] [pulsar] Shoothzj commented on a change in pull request #13390: [security] Allow config client dns bind addr and port

[GitBox <gi...@apache.org>]

Shoothzj commented on a change in pull request #13390:
URL: https://github.com/apache/pulsar/pull/13390#discussion_r773074132



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
##########
@@ -342,14 +355,6 @@ public long getLookupTimeoutMs() {
         }
     }
 
-    public ClientConfigurationData clone() {
-        try {
-            return (ClientConfigurationData) super.clone();
-        } catch (CloneNotSupportedException e) {
-            throw new RuntimeException("Failed to clone ClientConfigurationData");
-        }
-    }
-

Review comment:
       I move this method to the end of file. Make all the `get methods` together for better reading.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org