You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vishalkardode <gi...@git.apache.org> on 2016/03/04 06:43:38 UTC
[GitHub] cordova-plugin-camera pull request: Fix Crash on Android 6.0 for p...
GitHub user vishalkardode opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/189
Fix Crash on Android 6.0 for permissions
Removed check `fileWillBeModified` before requesting runtime Permissions.
When you don't specify image height / width for picker, plugin does not ask for `READ_EXTERNAL_STORAGE `permission and results in crash while file selection.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vishalkardode/cordova-plugin-camera master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #189
----
commit 9a9fd25ef992677aaaf6180b1d5bab72b90e9289
Author: Vishal Kardode <vi...@gmail.com>
Date: 2016-03-04T05:40:38Z
Fix Crash on Android 6.0 for permissions
Removed check `fileWillBeModified` before requesting runtime Permissions.
When you don't specify image height / width for picker, plugin does not ask for READ_EXTERNAL_STORAGE permission and results in crash while file selection.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix Crash on Android 6.0 for p...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/189#issuecomment-194618222
This was just fixed in a19c752
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix Crash on Android 6.0 for p...
Posted by vishalkardode <gi...@git.apache.org>.
Github user vishalkardode closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org