You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Josh Rosen (Jira)" <ji...@apache.org> on 2024/06/21 22:52:00 UTC

[jira] [Updated] (SPARK-48686) Improve performance of ParserUtils.unescapeSQLString

     [ https://issues.apache.org/jira/browse/SPARK-48686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Josh Rosen updated SPARK-48686:
-------------------------------
    Description: 
The `ParserUtils.unescapeSQLString` method is currently implemented using regexes for part of the parsing, but is costly because multiple Matcher instances are created for every input cahracter.

I think that we should optimize this to remove the use of regexes.

I will submit a PR for this.

  was:
The `ParserUtils.unescapeSQLString` method is currently implemented using regexes for part of the parsing, but this slows down the common case where escaping is not needed and may be prone to O(n^2) behavior for certain extreme inputs.

I think that we should optimize this to remove the use of regexes.

I will submit a PR for this.


> Improve performance of ParserUtils.unescapeSQLString
> ----------------------------------------------------
>
>                 Key: SPARK-48686
>                 URL: https://issues.apache.org/jira/browse/SPARK-48686
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 4.0.0
>            Reporter: Josh Rosen
>            Assignee: Josh Rosen
>            Priority: Major
>
> The `ParserUtils.unescapeSQLString` method is currently implemented using regexes for part of the parsing, but is costly because multiple Matcher instances are created for every input cahracter.
> I think that we should optimize this to remove the use of regexes.
> I will submit a PR for this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org