You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/11/28 07:10:15 UTC
[GitHub] [rocketmq-exporter] ifplusor commented on a change in pull request #32: Support ACL
ifplusor commented on a change in pull request #32:
URL: https://github.com/apache/rocketmq-exporter/pull/32#discussion_r531966085
##########
File path: src/main/java/org/apache/rocketmq/exporter/config/RMQConfigure.java
##########
@@ -43,6 +43,23 @@
private volatile String webTelemetryPath = System.getProperty(ROCKETMQ_CONFIG_WEB_TELEMETRY_PATH, "/metrics");
private volatile String rocketmqVersion = System.getProperty(ROCKETMQ_CONFIG_ROCKETMQ_VERSION, "V4_3_2");
+ /**
Review comment:
Here need a blank line.
##########
File path: src/main/java/org/apache/rocketmq/exporter/service/client/MQAdminInstance.java
##########
@@ -39,12 +42,30 @@
@Service
public class MQAdminInstance {
private final static Logger log = LoggerFactory.getLogger(MQAdminInstance.class);
- @Autowired
private RMQConfigure configure;
+ private RPCHook aclHook;
Review comment:
Why not a bean?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org