You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2026/01/23 08:41:14 UTC
[PR] HBASE-29454: Update hbase-examples scripts to be compatible with Pyth… [hbase]
liuxiaocs7 opened a new pull request, #7671:
URL: https://github.com/apache/hbase/pull/7671
…on 3 (#7161)
Reviewed by: Kota-SH <sh...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29454: Update hbase-examples scripts to be compatible with Pyth… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7671:
URL: https://github.com/apache/hbase/pull/7671#issuecomment-3790509668
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 32s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-3 Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 25s | | branch-3 passed |
| +1 :green_heart: | javadoc | 2m 45s | | branch-3 passed |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 10s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 43s | | the patch passed |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 317m 56s | | root in the patch passed. |
| | | 339m 48s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7671/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7671 |
| Optional Tests | javac javadoc unit |
| uname | Linux c734b0cf2c6f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-3 / d0b1d3d8a99bb3c6a4792885183024f4744c264a |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7671/1/testReport/ |
| Max. process+thread count | 8082 (vs. ulimit of 30000) |
| modules | C: hbase-server hbase-examples . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7671/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29454: Update hbase-examples scripts to be compatible with Pyth… [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7671:
URL: https://github.com/apache/hbase/pull/7671#issuecomment-3789186943
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 45s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ branch-3 Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 39s | | branch-3 passed |
| +1 :green_heart: | spotless | 1m 15s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 39s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | pylint | 1m 42s | [/results-pylint.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7671/1/artifact/yetus-general-check/output/results-pylint.txt) | The patch generated 3 new + 2022 unchanged - 4 fixed = 2025 total (was 2026) |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | spotless | 1m 11s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 57s | | The patch does not generate ASF License warnings. |
| | | 18m 14s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7671/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7671 |
| Optional Tests | dupname asflicense codespell detsecrets spotless javac pylint shellcheck shelldocs |
| uname | Linux acfe184b088a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-3 / d0b1d3d8a99bb3c6a4792885183024f4744c264a |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 83 (vs. ulimit of 30000) |
| modules | C: hbase-server hbase-examples . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7671/1/console |
| versions | git=2.34.1 maven=3.9.8 pylint=2.15.5 shellcheck=0.8.0 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29454 Update hbase-examples scripts to be compatible with Pyth… [hbase]
Posted by "guluo2016 (via GitHub)" <gi...@apache.org>.
guluo2016 commented on code in PR #7671:
URL: https://github.com/apache/hbase/pull/7671#discussion_r2754667570
##########
hbase-examples/src/main/python/thrift1/DemoClient.py:
##########
@@ -131,25 +123,25 @@ def demo_client(host, port, is_framed_transport):
try:
mutations = [Mutation(column="entry:foo", value=invalid)]
client.mutateRow(t, invalid, mutations, dummy_attributes)
- except ttypes.IOError, e:
- print 'expected exception: %s' %(e.message)
+ except ttypes.IOError as e:
+ print(f'expected exception: {e.message}')
# Run a scanner on the rows we just created
- print "Starting scanner..."
+ print("Starting scanner...")
scanner = client.scannerOpen(t, "", ["entry:"], dummy_attributes)
r = client.scannerGet(scanner)
while r:
printRow(r[0])
r = client.scannerGet(scanner)
- print "Scanner finished"
+ print("Scanner finished")
#
# Run some operations on a bunch of rows.
#
for e in range(100, 0, -1):
# format row keys as "00000" to "00100"
- row = "%0.5d" % (e)
+ row = f"{row:05}"
Review Comment:
There is an error in here, should use `e` .
```
row = f"{row:05}"
^^^
NameError: name 'row' is not defined. Did you mean: 'pow'?
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29454 Update hbase-examples scripts to be compatible with Pyth… [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #7671:
URL: https://github.com/apache/hbase/pull/7671#discussion_r2754805751
##########
hbase-examples/src/main/python/thrift1/DemoClient.py:
##########
@@ -131,25 +123,25 @@ def demo_client(host, port, is_framed_transport):
try:
mutations = [Mutation(column="entry:foo", value=invalid)]
client.mutateRow(t, invalid, mutations, dummy_attributes)
- except ttypes.IOError, e:
- print 'expected exception: %s' %(e.message)
+ except ttypes.IOError as e:
+ print(f'expected exception: {e.message}')
# Run a scanner on the rows we just created
- print "Starting scanner..."
+ print("Starting scanner...")
scanner = client.scannerOpen(t, "", ["entry:"], dummy_attributes)
r = client.scannerGet(scanner)
while r:
printRow(r[0])
r = client.scannerGet(scanner)
- print "Scanner finished"
+ print("Scanner finished")
#
# Run some operations on a bunch of rows.
#
for e in range(100, 0, -1):
# format row keys as "00000" to "00100"
- row = "%0.5d" % (e)
+ row = f"{row:05}"
Review Comment:
Hi, @guluo2016, HBase-23644(https://github.com/apache/hbase/pull/7530) depends on HBASE-29454 on branch-3, HBase-23644 will be backport after HBASE-29454 in branch-3 and should fix this problem, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29454 Update hbase-examples scripts to be compatible with Pyth… [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #7671:
URL: https://github.com/apache/hbase/pull/7671#discussion_r2754805751
##########
hbase-examples/src/main/python/thrift1/DemoClient.py:
##########
@@ -131,25 +123,25 @@ def demo_client(host, port, is_framed_transport):
try:
mutations = [Mutation(column="entry:foo", value=invalid)]
client.mutateRow(t, invalid, mutations, dummy_attributes)
- except ttypes.IOError, e:
- print 'expected exception: %s' %(e.message)
+ except ttypes.IOError as e:
+ print(f'expected exception: {e.message}')
# Run a scanner on the rows we just created
- print "Starting scanner..."
+ print("Starting scanner...")
scanner = client.scannerOpen(t, "", ["entry:"], dummy_attributes)
r = client.scannerGet(scanner)
while r:
printRow(r[0])
r = client.scannerGet(scanner)
- print "Scanner finished"
+ print("Scanner finished")
#
# Run some operations on a bunch of rows.
#
for e in range(100, 0, -1):
# format row keys as "00000" to "00100"
- row = "%0.5d" % (e)
+ row = f"{row:05}"
Review Comment:
Hi, @guluo2016, HBase-23644(https://github.com/apache/hbase/pull/7530) depends on HBASE-29454 on branch-3, HBase-23644 will be backported after HBASE-29454 in branch-3 and should fix this problem, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29454 Update hbase-examples scripts to be compatible with Pyth… [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #7671:
URL: https://github.com/apache/hbase/pull/7671#discussion_r2754805751
##########
hbase-examples/src/main/python/thrift1/DemoClient.py:
##########
@@ -131,25 +123,25 @@ def demo_client(host, port, is_framed_transport):
try:
mutations = [Mutation(column="entry:foo", value=invalid)]
client.mutateRow(t, invalid, mutations, dummy_attributes)
- except ttypes.IOError, e:
- print 'expected exception: %s' %(e.message)
+ except ttypes.IOError as e:
+ print(f'expected exception: {e.message}')
# Run a scanner on the rows we just created
- print "Starting scanner..."
+ print("Starting scanner...")
scanner = client.scannerOpen(t, "", ["entry:"], dummy_attributes)
r = client.scannerGet(scanner)
while r:
printRow(r[0])
r = client.scannerGet(scanner)
- print "Scanner finished"
+ print("Scanner finished")
#
# Run some operations on a bunch of rows.
#
for e in range(100, 0, -1):
# format row keys as "00000" to "00100"
- row = "%0.5d" % (e)
+ row = f"{row:05}"
Review Comment:
Hi, @guluo2016, HBase-23644(https://github.com/apache/hbase/pull/7530) and HBASE-29457 (https://github.com/apache/hbase/pull/7529) depends on HBASE-29454 on branch-3, HBase-23644 and HBASE-29457 will be backported after HBASE-29454 in branch-3 and should fix this problem, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29454 Update hbase-examples scripts to be compatible with Pyth… [hbase]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on code in PR #7671:
URL: https://github.com/apache/hbase/pull/7671#discussion_r2754805751
##########
hbase-examples/src/main/python/thrift1/DemoClient.py:
##########
@@ -131,25 +123,25 @@ def demo_client(host, port, is_framed_transport):
try:
mutations = [Mutation(column="entry:foo", value=invalid)]
client.mutateRow(t, invalid, mutations, dummy_attributes)
- except ttypes.IOError, e:
- print 'expected exception: %s' %(e.message)
+ except ttypes.IOError as e:
+ print(f'expected exception: {e.message}')
# Run a scanner on the rows we just created
- print "Starting scanner..."
+ print("Starting scanner...")
scanner = client.scannerOpen(t, "", ["entry:"], dummy_attributes)
r = client.scannerGet(scanner)
while r:
printRow(r[0])
r = client.scannerGet(scanner)
- print "Scanner finished"
+ print("Scanner finished")
#
# Run some operations on a bunch of rows.
#
for e in range(100, 0, -1):
# format row keys as "00000" to "00100"
- row = "%0.5d" % (e)
+ row = f"{row:05}"
Review Comment:
Hi, @guluo2016, HBase-23644(https://github.com/apache/hbase/pull/7530) depends on HBASE-29454 on branch-3, HBase-23644 should fix this problem, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29454 Update hbase-examples scripts to be compatible with Pyth… [hbase]
Posted by "guluo2016 (via GitHub)" <gi...@apache.org>.
guluo2016 merged PR #7671:
URL: https://github.com/apache/hbase/pull/7671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29454 Update hbase-examples scripts to be compatible with Pyth… [hbase]
Posted by "guluo2016 (via GitHub)" <gi...@apache.org>.
guluo2016 commented on code in PR #7671:
URL: https://github.com/apache/hbase/pull/7671#discussion_r2764211604
##########
hbase-examples/src/main/python/thrift1/DemoClient.py:
##########
@@ -131,25 +123,25 @@ def demo_client(host, port, is_framed_transport):
try:
mutations = [Mutation(column="entry:foo", value=invalid)]
client.mutateRow(t, invalid, mutations, dummy_attributes)
- except ttypes.IOError, e:
- print 'expected exception: %s' %(e.message)
+ except ttypes.IOError as e:
+ print(f'expected exception: {e.message}')
# Run a scanner on the rows we just created
- print "Starting scanner..."
+ print("Starting scanner...")
scanner = client.scannerOpen(t, "", ["entry:"], dummy_attributes)
r = client.scannerGet(scanner)
while r:
printRow(r[0])
r = client.scannerGet(scanner)
- print "Scanner finished"
+ print("Scanner finished")
#
# Run some operations on a bunch of rows.
#
for e in range(100, 0, -1):
# format row keys as "00000" to "00100"
- row = "%0.5d" % (e)
+ row = f"{row:05}"
Review Comment:
Got it, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org