You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2023/04/24 16:12:55 UTC

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #19021: [Feature](index) support token_bf index for token search

github-actions[bot] commented on code in PR #19021:
URL: https://github.com/apache/doris/pull/19021#discussion_r1175513933


##########
be/src/olap/itoken_extractor.h:
##########
@@ -93,6 +93,19 @@ struct NgramTokenExtractor final : public ITokenExtractorHelper<NgramTokenExtrac
 private:
     size_t n;
 };
+
+/// Parser extracting all splits from string.
+struct SplitTokenExtractor final : public ITokenExtractorHelper<SplitTokenExtractor> {
+public:
+    SplitTokenExtractor() {}

Review Comment:
   warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
   
   ```suggestion
       SplitTokenExtractor() = default;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org