You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by gg...@apache.org on 2020/11/23 23:37:18 UTC

[httpcomponents-core] 04/06: Remove redundant returns.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch 4.4.x
in repository https://gitbox.apache.org/repos/asf/httpcomponents-core.git

commit 1b19e4cb4f75a352b43fce78d040fcf40752be77
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Nov 23 12:18:03 2020 -0500

    Remove redundant returns.
---
 .../org/apache/http/impl/SocketHttpClientConnection.java                | 2 +-
 .../org/apache/http/impl/SocketHttpServerConnection.java                | 2 +-
 httpcore/src/main/java/org/apache/http/entity/ContentType.java          | 2 +-
 httpcore/src/main/java/org/apache/http/impl/BHttpConnectionBase.java    | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/httpcore/src/main/java-deprecated/org/apache/http/impl/SocketHttpClientConnection.java b/httpcore/src/main/java-deprecated/org/apache/http/impl/SocketHttpClientConnection.java
index f3cf3ed..38f8b5a 100644
--- a/httpcore/src/main/java-deprecated/org/apache/http/impl/SocketHttpClientConnection.java
+++ b/httpcore/src/main/java-deprecated/org/apache/http/impl/SocketHttpClientConnection.java
@@ -212,7 +212,7 @@ public class SocketHttpClientConnection
             try {
                 return this.socket.getSoTimeout();
             } catch (final SocketException ignore) {
-                return -1;
+                // ignore
             }
         }
         return -1;
diff --git a/httpcore/src/main/java-deprecated/org/apache/http/impl/SocketHttpServerConnection.java b/httpcore/src/main/java-deprecated/org/apache/http/impl/SocketHttpServerConnection.java
index 3caca45..4c6f7b1 100644
--- a/httpcore/src/main/java-deprecated/org/apache/http/impl/SocketHttpServerConnection.java
+++ b/httpcore/src/main/java-deprecated/org/apache/http/impl/SocketHttpServerConnection.java
@@ -204,7 +204,7 @@ public class SocketHttpServerConnection extends
             try {
                 return this.socket.getSoTimeout();
             } catch (final SocketException ignore) {
-                return -1;
+                // ignore
             }
         }
         return -1;
diff --git a/httpcore/src/main/java/org/apache/http/entity/ContentType.java b/httpcore/src/main/java/org/apache/http/entity/ContentType.java
index 4736d83..f3cb18b 100644
--- a/httpcore/src/main/java/org/apache/http/entity/ContentType.java
+++ b/httpcore/src/main/java/org/apache/http/entity/ContentType.java
@@ -370,7 +370,7 @@ public final class ContentType implements Serializable {
                     return create(elements[0], false);
                 }
             } catch (final ParseException ex) {
-                return null;
+                // ignore
             }
         }
         return null;
diff --git a/httpcore/src/main/java/org/apache/http/impl/BHttpConnectionBase.java b/httpcore/src/main/java/org/apache/http/impl/BHttpConnectionBase.java
index 3787a7b..e59b299 100644
--- a/httpcore/src/main/java/org/apache/http/impl/BHttpConnectionBase.java
+++ b/httpcore/src/main/java/org/apache/http/impl/BHttpConnectionBase.java
@@ -289,7 +289,7 @@ public class BHttpConnectionBase implements HttpInetConnection {
             try {
                 return socket.getSoTimeout();
             } catch (final SocketException ignore) {
-                return -1;
+                // ignore
             }
         }
         return -1;