[GitHub] [calcite] liyafan82 commented on a change in pull request #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration

[GitBox <gi...@apache.org>]

liyafan82 commented on a change in pull request #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration
URL: https://github.com/apache/calcite/pull/1901#discussion_r405951168
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
 ##########
 @@ -185,6 +187,10 @@
    * time. */
   private static final ReentrantLock LOCK = new ReentrantLock();
 
+  static {
+    System.setProperty("calcite.enable.regenerate.metadata.handler", "false");
 
 Review comment:
   Thanks for the feedback.
   
   It seems to make the setting take effect, we have to set the system property before class CalciteSystemProperty is loaded. So we have to set it in the static constructor. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services