You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by Sean Owen <sr...@gmail.com> on 2010/01/21 01:34:14 UTC
Build issue with last dirichlet change
That last commit concerning the dirichlet code and models seems to
cause the build to fail -- or else I'm the victim of another
environment-specific issue.
I note it only because the fix raises a question. It causes core/ to
depend utils/, and I had thought that was not the idea?
Sean
Re: Build issue with last dirichlet change
Posted by Sean Owen <sr...@gmail.com>.
I don't think there's any practical or conceptual problem with core
*tests* depending on utils.
On Wed, Jan 20, 2010 at 5:13 PM, Benson Margulies <bi...@gmail.com> wrote:
> You may have hit a classic maven annoyance which is shared test code.
> Generally, people seem to end up with more modules than they expected
> to.
Re: Build issue with last dirichlet change
Posted by Benson Margulies <bi...@gmail.com>.
You may have hit a classic maven annoyance which is shared test code.
Generally, people seem to end up with more modules than they expected
to.
On Wed, Jan 20, 2010 at 8:06 PM, Ted Dunning <te...@gmail.com> wrote:
> Our modules aren't working out as well as expected.
>
> On Wed, Jan 20, 2010 at 4:56 PM, Jeff Eastman <jd...@windwardsolutions.com>wrote:
>
>> Sean Owen wrote:
>>
>>> That last commit concerning the dirichlet code and models seems to
>>> cause the build to fail -- or else I'm the victim of another
>>> environment-specific issue.
>>>
>>> I note it only because the fix raises a question. It causes core/ to
>>> depend utils/, and I had thought that was not the idea?
>>>
>>> Sean
>>>
>>>
>>>
>> Oh darn, my new unit test does depend upon utils for the TFIDF stuff. Where
>> should I move it to?
>>
>
>
>
> --
> Ted Dunning, CTO
> DeepDyve
>
Re: Build issue with last dirichlet change
Posted by Jake Mannix <ja...@gmail.com>.
TestVectorWritable fails? What is it saying in the surefire report?
-jake
On Wed, Jan 20, 2010 at 5:42 PM, Jeff Eastman <jd...@windwardsolutions.com>wrote:
> The build compiles but org.apache.mahout.math.TestVectorWritable fails for
> some reason and it does not get to my test.
>
>
>
> Jeff Eastman wrote:
>
>> I will run the build before I commit.
>> I will run the build before I commit.
>> ...
>> I will run the build before I commit.
>>
>> my bad
>>
>>
>> Ted Dunning wrote:
>>
>>> Our modules aren't working out as well as expected.
>>>
>>> On Wed, Jan 20, 2010 at 4:56 PM, Jeff Eastman <
>>> jdog@windwardsolutions.com>wrote:
>>>
>>>
>>>
>>>> Sean Owen wrote:
>>>>
>>>>
>>>>
>>>>> That last commit concerning the dirichlet code and models seems to
>>>>> cause the build to fail -- or else I'm the victim of another
>>>>> environment-specific issue.
>>>>>
>>>>> I note it only because the fix raises a question. It causes core/ to
>>>>> depend utils/, and I had thought that was not the idea?
>>>>>
>>>>> Sean
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>> Oh darn, my new unit test does depend upon utils for the TFIDF stuff.
>>>> Where
>>>> should I move it to?
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>
Re: Build issue with last dirichlet change
Posted by Jeff Eastman <jd...@windwardsolutions.com>.
Whew! doing a clean build resolved the phantom test class. All tests
pass, even mine :)
Jeff Eastman wrote:
> The build compiles but org.apache.mahout.math.TestVectorWritable fails
> for some reason and it does not get to my test.
>
>
> Jeff Eastman wrote:
>> I will run the build before I commit.
>> I will run the build before I commit.
>> ...
>> I will run the build before I commit.
>>
>> my bad
>>
>>
>> Ted Dunning wrote:
>>> Our modules aren't working out as well as expected.
>>>
>>> On Wed, Jan 20, 2010 at 4:56 PM, Jeff Eastman
>>> <jd...@windwardsolutions.com>wrote:
>>>
>>>
>>>> Sean Owen wrote:
>>>>
>>>>
>>>>> That last commit concerning the dirichlet code and models seems to
>>>>> cause the build to fail -- or else I'm the victim of another
>>>>> environment-specific issue.
>>>>>
>>>>> I note it only because the fix raises a question. It causes core/ to
>>>>> depend utils/, and I had thought that was not the idea?
>>>>>
>>>>> Sean
>>>>>
>>>>>
>>>>>
>>>>>
>>>> Oh darn, my new unit test does depend upon utils for the TFIDF
>>>> stuff. Where
>>>> should I move it to?
>>>>
>>>>
>>>
>>>
>>>
>>>
>>
>>
>
>
Re: Build issue with last dirichlet change
Posted by Jeff Eastman <jd...@windwardsolutions.com>.
The build compiles but org.apache.mahout.math.TestVectorWritable fails
for some reason and it does not get to my test.
Jeff Eastman wrote:
> I will run the build before I commit.
> I will run the build before I commit.
> ...
> I will run the build before I commit.
>
> my bad
>
>
> Ted Dunning wrote:
>> Our modules aren't working out as well as expected.
>>
>> On Wed, Jan 20, 2010 at 4:56 PM, Jeff Eastman
>> <jd...@windwardsolutions.com>wrote:
>>
>>
>>> Sean Owen wrote:
>>>
>>>
>>>> That last commit concerning the dirichlet code and models seems to
>>>> cause the build to fail -- or else I'm the victim of another
>>>> environment-specific issue.
>>>>
>>>> I note it only because the fix raises a question. It causes core/ to
>>>> depend utils/, and I had thought that was not the idea?
>>>>
>>>> Sean
>>>>
>>>>
>>>>
>>>>
>>> Oh darn, my new unit test does depend upon utils for the TFIDF
>>> stuff. Where
>>> should I move it to?
>>>
>>>
>>
>>
>>
>>
>
>
Re: Build issue with last dirichlet change
Posted by Jeff Eastman <jd...@windwardsolutions.com>.
I will run the build before I commit.
I will run the build before I commit.
...
I will run the build before I commit.
my bad
Ted Dunning wrote:
> Our modules aren't working out as well as expected.
>
> On Wed, Jan 20, 2010 at 4:56 PM, Jeff Eastman <jd...@windwardsolutions.com>wrote:
>
>
>> Sean Owen wrote:
>>
>>
>>> That last commit concerning the dirichlet code and models seems to
>>> cause the build to fail -- or else I'm the victim of another
>>> environment-specific issue.
>>>
>>> I note it only because the fix raises a question. It causes core/ to
>>> depend utils/, and I had thought that was not the idea?
>>>
>>> Sean
>>>
>>>
>>>
>>>
>> Oh darn, my new unit test does depend upon utils for the TFIDF stuff. Where
>> should I move it to?
>>
>>
>
>
>
>
Re: Build issue with last dirichlet change
Posted by Ted Dunning <te...@gmail.com>.
Our modules aren't working out as well as expected.
On Wed, Jan 20, 2010 at 4:56 PM, Jeff Eastman <jd...@windwardsolutions.com>wrote:
> Sean Owen wrote:
>
>> That last commit concerning the dirichlet code and models seems to
>> cause the build to fail -- or else I'm the victim of another
>> environment-specific issue.
>>
>> I note it only because the fix raises a question. It causes core/ to
>> depend utils/, and I had thought that was not the idea?
>>
>> Sean
>>
>>
>>
> Oh darn, my new unit test does depend upon utils for the TFIDF stuff. Where
> should I move it to?
>
--
Ted Dunning, CTO
DeepDyve
Re: Build issue with last dirichlet change
Posted by Jeff Eastman <jd...@windwardsolutions.com>.
I can easily move it into the /utils/test subtree. Tried that and it now
builds ok. I actually like it fine there with the Lucene/text stuff.
Sean Owen wrote:
> Actually, I suppose it's not a big deal if core *tests* depend on
> utils. I can make that adjustment if that sounds right.
>
> On Wed, Jan 20, 2010 at 4:56 PM, Jeff Eastman
> <jd...@windwardsolutions.com> wrote:
>
>> Sean Owen wrote:
>>
>>> That last commit concerning the dirichlet code and models seems to
>>> cause the build to fail -- or else I'm the victim of another
>>> environment-specific issue.
>>>
>>> I note it only because the fix raises a question. It causes core/ to
>>> depend utils/, and I had thought that was not the idea?
>>>
>>> Sean
>>>
>>>
>>>
>> Oh darn, my new unit test does depend upon utils for the TFIDF stuff. Where
>> should I move it to?
>>
>>
>
>
Re: Build issue with last dirichlet change
Posted by Sean Owen <sr...@gmail.com>.
Actually, I suppose it's not a big deal if core *tests* depend on
utils. I can make that adjustment if that sounds right.
On Wed, Jan 20, 2010 at 4:56 PM, Jeff Eastman
<jd...@windwardsolutions.com> wrote:
> Sean Owen wrote:
>>
>> That last commit concerning the dirichlet code and models seems to
>> cause the build to fail -- or else I'm the victim of another
>> environment-specific issue.
>>
>> I note it only because the fix raises a question. It causes core/ to
>> depend utils/, and I had thought that was not the idea?
>>
>> Sean
>>
>>
>
> Oh darn, my new unit test does depend upon utils for the TFIDF stuff. Where
> should I move it to?
>
Re: Build issue with last dirichlet change
Posted by Jeff Eastman <jd...@windwardsolutions.com>.
Sean Owen wrote:
> That last commit concerning the dirichlet code and models seems to
> cause the build to fail -- or else I'm the victim of another
> environment-specific issue.
>
> I note it only because the fix raises a question. It causes core/ to
> depend utils/, and I had thought that was not the idea?
>
> Sean
>
>
Oh darn, my new unit test does depend upon utils for the TFIDF stuff.
Where should I move it to?