[GitHub] [pulsar] lhotari commented on a diff in pull request #16045: [fix][proxy] Use correct channel for HAProxyMessage dest address

[GitBox <gi...@apache.org>]

lhotari commented on code in PR #16045:
URL: https://github.com/apache/pulsar/pull/16045#discussion_r896777535


##########
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/DirectProxyHandler.java:
##########
@@ -233,7 +233,7 @@ private void writeHAProxyMessage() {
                 InetSocketAddress clientAddress = (InetSocketAddress) inboundChannel.remoteAddress();
                 String sourceAddress = clientAddress.getAddress().getHostAddress();
                 int sourcePort = clientAddress.getPort();
-                InetSocketAddress proxyAddress = (InetSocketAddress) inboundChannel.remoteAddress();
+                InetSocketAddress proxyAddress = (InetSocketAddress) outboundChannel.localAddress();

Review Comment:
   I think that it should be using `outboundChannel.remoteAddress()` instead of `.localAddress()`. 
   ```suggestion
                   InetSocketAddress proxyAddress = (InetSocketAddress) outboundChannel.remoteAddress();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org