[GitHub] [airflow] ashb commented on a change in pull request #7597: [AIRFLOW-6497] Avoid loading DAGs in the main scheduler loop

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #7597: [AIRFLOW-6497] Avoid loading DAGs in the main scheduler loop
URL: https://github.com/apache/airflow/pull/7597#discussion_r386339683
 
 

 ##########
 File path: airflow/jobs/scheduler_job.py
 ##########
 @@ -1616,26 +1633,6 @@ def _validate_and_run_task_instances(self, simple_dag_bag: SimpleDagBag) -> bool
         self._process_executor_events(simple_dag_bag)
         return True
 
-    def _process_and_execute_tasks(self, simple_dag_bag):
 
 Review comment:
   Moving code around like this makes PRs harder to review -- as you are mixing two different things here and making more work for reviewers -- and this change is unrelated to "not loading DAGs in main scheduler loop".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services