You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/20 22:19:15 UTC
[GitHub] [airflow] PApostol opened a new pull request, #27808: Improve filtering for invalid schemas in Hive hook
PApostol opened a new pull request, #27808:
URL: https://github.com/apache/airflow/pull/27808
Closes #27695. Improved invalid character detection for schemas in Hive hook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #27808: Improve filtering for invalid schemas in Hive hook
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27808:
URL: https://github.com/apache/airflow/pull/27808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #27808: Improve filtering for invalid schemas in Hive hook
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #27808:
URL: https://github.com/apache/airflow/pull/27808#discussion_r1027508096
##########
tests/providers/apache/hive/hooks/test_hive.py:
##########
@@ -133,10 +133,12 @@ def test_run_cli(self, mock_popen, mock_temp_dir):
)
def test_hive_cli_hook_invalid_schema(self):
- with pytest.raises(RuntimeError):
+ with pytest.raises(RuntimeError) as error:
hook = InvalidHiveCliHook()
hook.run_cli("SHOW DATABASES")
+ assert ";" in str(error.value)
Review Comment:
It’s better to check the entire error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org