You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/11/21 23:32:13 UTC
[GitHub] [avro] andeb opened a new pull request, #1979: java: Produce valid string for UUID JSON serialization
andeb opened a new pull request, #1979:
URL: https://github.com/apache/avro/pull/1979
<!--
*Thank you very much for contributing to Apache Avro - we are happy that you want to help us improve Avro. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Avro a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/AVRO/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "AVRO-XXXX: [component] Title of the pull request", where *AVRO-XXXX* should be replaced by the actual issue number.
The *component* is optional, but can help identify the correct reviewers faster: either the language ("java", "python") or subsystem such as "build" or "doc" are good candidates.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests. You can [build the entire project](https://github.com/apache/avro/blob/master/BUILD.md) or just the [language-specific SDK](https://avro.apache.org/project/how-to-contribute/#unit-tests).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Every commit message references Jira issues in their subject lines. In addition, commits follow the guidelines from [How to write a good git commit message](https://chris.beams.io/posts/git-commit/)
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
-->
## What is the purpose of the change
In addition to https://github.com/apache/avro/pull/1204, this pull request wraps UUIDs in quotes to produce a valid JSON.
## Verifying this change
Added test that validates UUID toString() behaviour
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1979: AVRO-3676: Produce valid toString() for UUID JSON
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on PR #1979:
URL: https://github.com/apache/avro/pull/1979#issuecomment-1325508733
Cherry-picked to [branch-1.11](https://github.com/apache/avro/commit/f789886517c97092664d1ea9e13ad312c522d78a).
I also created a JIRA to track this change: AVRO-3676 -- The ASF JIRA unfortunately needed to disable [public signups](https://infra.apache.org/blog/jira-public-signup-disabled.html) -- would you like us to create an account for you for contributor credit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] andeb commented on pull request #1979: AVRO-3676: Produce valid toString() for UUID JSON
Posted by GitBox <gi...@apache.org>.
andeb commented on PR #1979:
URL: https://github.com/apache/avro/pull/1979#issuecomment-1331341977
Thank you @RyanSkraba. It would be great if you could create an account for me on JIRA.
Noted regarding data representation using `.toString()`. I use it as a trick for tests only where I assert some big Avro JSONs to the expected JSON in some tests.
Originally I was using `JsonEncoder` to generate the Avro JSON, however it was a bit tricky to assert fields with `logicalType` `decimal` and `timestamp` as they get encoded as `byte` and `long` and it is not immediately clear the conversion when reading the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #1979: AVRO-3676: Produce valid toString() for UUID JSON
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged PR #1979:
URL: https://github.com/apache/avro/pull/1979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org