[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1325: ORC-1322: Upgrade centos7 docker image to use gcc 9

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #1325:
URL: https://github.com/apache/orc/pull/1325#discussion_r1034235285


##########
docker/run-one.sh:
##########
@@ -37,7 +37,7 @@ else
 
   echo "Started $GITHUB_USER/$BRANCH on $BUILD at $(date)"
 
-  docker run $VOLUME "$TAG" /bin/bash -c \
+  docker run $VOLUME "$TAG" /bin/bash --login -c \

Review Comment:
   If I tried to CentOS on this PR, it seems that it has side-effects, @wgtmac . Did you try to run all the other OSes actually?
   ```
   $ ./run-one.sh local main centos7
   Started local run for ORC-1320 on centos7 at Mon Nov 28 18:17:02 PST 2022
   /etc/profile.d/lang.sh: line 19: warning: setlocale: LC_CTYPE: cannot change locale (en_US.UTF-8): No such file or directory
   /etc/profile.d/lang.sh: line 20: warning: setlocale: LC_COLLATE: cannot change locale (en_US.UTF-8): No such file or directory
   /etc/profile.d/lang.sh: line 23: warning: setlocale: LC_MESSAGES: cannot change locale (en_US.UTF-8): No such file or directory
   /etc/profile.d/lang.sh: line 26: warning: setlocale: LC_NUMERIC: cannot change locale (en_US.UTF-8): No such file or directory
   /etc/profile.d/lang.sh: line 29: warning: setlocale: LC_TIME: cannot change locale (en_US.UTF-8): No such file or directory
   -- The C compiler identification is GNU 9.3.1
   -- The CXX compiler identification is GNU 9.3.1
   ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org