You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2019/12/28 07:49:03 UTC
[GitHub] [incubator-echarts] daming-lu opened a new pull request #11934: fix
https://github.com/apache/incubator-echarts/issues/11658
daming-lu opened a new pull request #11934: fix https://github.com/apache/incubator-echarts/issues/11658
URL: https://github.com/apache/incubator-echarts/pull/11934
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ X] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Fixed issue 11658
### Fixed issues
<!--
- #11658: ...
-->
## Details
开始时候我们有5个州： 幽州, 荆州, 兖州, 益州, 西凉
幽州 是 idx = 0, isSelected = true;
当点击 legend， hide 幽州之后，idx = 0 的就变成了荆州，piePieceProto.updateData will be called 4 times, not 5. 所以 idx 会指错。需要用 getName 来定位 item。
TODO： 未来可以考虑更好的封装，而不是用 index 或者 name 来让 parent 进行操作。不过可能重构工程量较大😆
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] daming-lu commented on issue #11934: fix
https://github.com/apache/incubator-echarts/issues/11658
Posted by GitBox <gi...@apache.org>.
daming-lu commented on issue #11934: fix https://github.com/apache/incubator-echarts/issues/11658
URL: https://github.com/apache/incubator-echarts/pull/11934#issuecomment-569397071
Here is the demo
https://www.bilibili.com/video/av80982279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on issue #11934: fix
https://github.com/apache/incubator-echarts/issues/11658
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #11934: fix https://github.com/apache/incubator-echarts/issues/11658
URL: https://github.com/apache/incubator-echarts/pull/11934#issuecomment-569565262
Nice work! Thanks a lot!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #11934: fix
https://github.com/apache/incubator-echarts/issues/11658
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #11934: fix https://github.com/apache/incubator-echarts/issues/11658
URL: https://github.com/apache/incubator-echarts/pull/11934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org