[GitHub] [inlong] pocozh commented on a diff in pull request #6351: [INLONG-6329][DataProxy] Add proxy-send mode message logic

[GitBox <gi...@apache.org>]

pocozh commented on code in PR #6351:
URL: https://github.com/apache/inlong/pull/6351#discussion_r1011110523


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/consts/AttributeConstants.java:
##########
@@ -88,6 +88,8 @@ public class AttributeConstants {
 
     public static final String MESSAGE_SYNC_SEND = "syncSend";
 
+    public static final String MESSAGE_PROXY_SEND = "proxySend";

Review Comment:
   It's better move these to common module, they are also used by`dataproxy-sdk` 



##########
inlong-common/src/main/java/org/apache/inlong/common/enums/DataProxyErrCode.java:
##########
@@ -27,7 +27,22 @@ public enum DataProxyErrCode {
     UNSUPPORTED_EXTENDFIELD_VALUE(3,
             "Unsupported extend field value"),
     UNCONFIGURED_GROUPID_OR_STREAMID(4,
-            "Un-configured groupId or streamId"),
+            "Unconfigured groupId or streamId"),
+    PUT_EVENT_TO_CHANNEL_FAILURE(5,
+            "Put event to Channels failure"),
+    TOPIC_IS_BLANK(6,
+            "Topic is null"),
+    NO_AVAILABLE_RPODUCERINFO(7,

Review Comment:
   typo, NO_AVAILABLE_PRODUCERINFO



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org