You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/10 21:08:15 UTC

[GitHub] [cloudstack] BryanMLima edited a comment on pull request #6081: [UI] Dont show project view menu when user doesn't have permission

BryanMLima edited a comment on pull request #6081:
URL: https://github.com/apache/cloudstack/pull/6081#issuecomment-1064458019


   When comparing a feature like live scaling a VM, it makes sense to disabled the button when the user has the permission to do so, but the API cannot be executed considering some external factors, like the VM is not dynamically scalable, for example. In this case, showing the user that he can live scale a VM makes sense, even though he can't in that specific case.  
   
   However, when considering the API `listProjects`, the side menu does not show the Project section, so it makes sense to hide the Project Menu on the top bar as well.
   
   Moreover, if the user has the permission to an API, then it should show at all times, even though the API can't be executed at that time, like the live scale mentioned above. In this case, it should be displayed as disabled. However, if the user doesn't have the permission to the API, it should not be displayed at all.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org