You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/19 02:56:01 UTC
[GitHub] [arrow] js8544 opened a new pull request, #14165: ARROW-17770: [C++][Gandiva] Fix const correctness of Gandiva projector Evaluate
js8544 opened a new pull request, #14165:
URL: https://github.com/apache/arrow/pull/14165
I was trying to figure out the thread-safeness of Gandiva projector evaluation, i.e., whether I can use a single Projector to evaluate multiple inputs concurrently. I assumed it isn't safe because the Evaluate function is not marked const. However, as far as I understand, the Evaluate function merely executes a compiled function on the input, which doesn't modify a project's internal states and should be const.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14165: ARROW-17770: [C++][Gandiva] Fix const correctness of Gandiva projector Evaluate
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14165:
URL: https://github.com/apache/arrow/pull/14165#issuecomment-1260063432
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14165: ARROW-17770: [C++][Gandiva] Fix const correctness of Gandiva projector Evaluate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14165:
URL: https://github.com/apache/arrow/pull/14165#issuecomment-1250498695
https://issues.apache.org/jira/browse/ARROW-17770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14165: ARROW-17770: [C++][Gandiva] Fix const correctness of Gandiva projector Evaluate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14165:
URL: https://github.com/apache/arrow/pull/14165#issuecomment-1260099975
Revision: 1d3b80591d7607740342e47c2c3a80b0a906de83
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b31c92d8e8](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b31c92d8e8)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-b31c92d8e8-github-java-jars)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14165: ARROW-17770: [C++][Gandiva] Fix const correctness of Gandiva projector Evaluate
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14165:
URL: https://github.com/apache/arrow/pull/14165#issuecomment-1259479153
Thank you for this @js8544 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14165: ARROW-17770: [C++][Gandiva] Fix const correctness of Gandiva projector Evaluate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14165:
URL: https://github.com/apache/arrow/pull/14165#issuecomment-1250498747
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14165: ARROW-17770: [C++][Gandiva] Fix const correctness of Gandiva projector Evaluate
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14165:
URL: https://github.com/apache/arrow/pull/14165#issuecomment-1259892216
Benchmark runs are scheduled for baseline = 4d0fbffdf6ebee3042c67abc7a87d5cd4491a23a and contender = 4ed79f7e3c2b9e83025042f396be5d60ce616020. 4ed79f7e3c2b9e83025042f396be5d60ce616020 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d1ab1078422b40068d172b3906ac64a7...5d9685a8f6a44d49ad752fab2cac258e/)
[Failed :arrow_down:0.51% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3fbfdb113a2540c8b6ea0c022fd4c720...5f897a697415440abd26a79054731646/)
[Failed :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8d10224363da4155be15b49fdca150b3...fa342df6bcf14a86bd7b2527783c7b15/)
[Finished :arrow_down:0.39% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/eb20fd5c95d14c9881d8d0ec26b1421a...8c903a0cbb944227b2437143784eaa26/)
Buildkite builds:
[Finished] [`4ed79f7e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1575)
[Failed] [`4ed79f7e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1593)
[Failed] [`4ed79f7e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1576)
[Finished] [`4ed79f7e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1589)
[Finished] [`4d0fbffd` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1574)
[Failed] [`4d0fbffd` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1592)
[Failed] [`4d0fbffd` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1575)
[Finished] [`4d0fbffd` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1588)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #14165: ARROW-17770: [C++][Gandiva] Fix const correctness of Gandiva projector Evaluate
Posted by GitBox <gi...@apache.org>.
pitrou merged PR #14165:
URL: https://github.com/apache/arrow/pull/14165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org