You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/02/01 19:21:15 UTC
[PR] HDDS-10274. Remove unused code related to AccessPolicy [ozone]
adoroszlai opened a new pull request, #6150:
URL: https://github.com/apache/ozone/pull/6150
## What changes were proposed in this pull request?
Remove `AccessPolicy` and related code, which is unused and leftover after HDDS-6909.
Motivation (beyond code cleanup): `AccessPolicy#deserializePolicyFromJsonString` is defined using GSON datatype `JsonObject`. We should strive to avoid using types defined in third-party libraries as part of public API. Such usage may cause trouble when trying to upgrade/replace these dependencies.
https://issues.apache.org/jira/browse/HDDS-10274
## How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7745385510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10274. Remove unused code related to AccessPolicy [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #6150:
URL: https://github.com/apache/ozone/pull/6150#issuecomment-1925193524
Thanks @fapifta, @smengcl for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10274. Remove unused code related to AccessPolicy [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #6150:
URL: https://github.com/apache/ozone/pull/6150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org