[GitHub] [lucene-solr] magibney commented on issue #892: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation

[GitBox <gi...@apache.org>]

magibney commented on issue #892: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation
URL: https://github.com/apache/lucene-solr/pull/892#issuecomment-562653015
 
 
   Thanks, @msokolov! Exposing and better documenting the constructors and rule modification/extraction (for use without the factory abstraction) would definitely be better. I will push an update shortly (if not today, then certainly by early next week).
   
   Regarding the test failure on 086697e, I've noticed that sometimes if I push twice in close succession, even with trivial changes the later push sometimes triggers a test failure -- maybe something about leftover build sandbox state? At this point it's happened enough that my working assumption is that the failures are spurious; as a workaround I'll probably try to wait a little longer between pushes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org