[GitHub] [incubator-seatunnel] liujinhui1994 commented on a change in pull request #1310: [Bug] [connector] Use Hudi source Serializable Exception

[GitBox <gi...@apache.org>]

liujinhui1994 commented on a change in pull request #1310:
URL: https://github.com/apache/incubator-seatunnel/pull/1310#discussion_r817429806



##########
File path: seatunnel-connectors/seatunnel-connector-spark-hudi/src/main/scala/org/apache/seatunnel/spark/sink/Hudi.scala
##########
@@ -41,7 +41,7 @@ class Hudi extends SparkBatchSink {
   override def output(df: Dataset[Row], environment: SparkEnvironment): Unit = {
     val writer = df.write.format("org.apache.hudi")
     for (e <- config.entrySet()) {
-      writer.option(e.getKey, e.getValue.toString)
+      writer.option(e.getKey, config.getString(e.getKey))

Review comment:
       ok
   

##########
File path: seatunnel-connectors/seatunnel-connector-spark-hudi/src/main/scala/org/apache/seatunnel/spark/source/Hudi.scala
##########
@@ -36,7 +36,7 @@ class Hudi extends SparkBatchSource {
 
     val reader = env.getSparkSession.read.format("org.apache.hudi")
     for (e <- config.entrySet()) {
-      reader.option(e.getKey, e.getValue.toString)
+      reader.option(e.getKey, config.getString(e.getKey))

Review comment:
       ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org