[GitHub] [solr] MarcusSorealheis commented on a change in pull request #42: SOLR-15277: Schema designer UI and supporting backend

[GitBox <gi...@apache.org>]

MarcusSorealheis commented on a change in pull request #42:
URL: https://github.com/apache/solr/pull/42#discussion_r644427250



##########
File path: solr/webapp/web/js/angular/app.js
##########
@@ -430,7 +436,11 @@ solrAdminApp.config([
         $location.path('/login');
       }
     } else {
-      $rootScope.exceptions[rejection.config.url] = rejection.data.error;
+      // schema designer prefers to handle errors itselft

Review comment:
       nit: drop the trailing `t` on this line.. reading closely. :)

##########
File path: solr/webapp/web/index.html
##########
@@ -26,6 +26,7 @@
   <link rel="stylesheet" type="text/css" href="css/angular/angular-csp.css?_=${version}">
   <link rel="stylesheet" type="text/css" href="css/angular/common.css?_=${version}">
   <link rel="stylesheet" type="text/css" href="css/angular/analysis.css?_=${version}">
+  <link rel="stylesheet" type="text/css" href="css/angular/schema-designer.css?_=${version}">
   <link rel="stylesheet" type="text/css" href="css/angular/cloud.css?_=${version}">
   <link rel="stylesheet" type="text/css" href="css/angular/cores.css?_=${version}">
   <link rel="stylesheet" type="text/css" href="css/angular/collections.css?_=${version}">

Review comment:
       another nit: the doctype should be changed to be HTML 5. It's as simple as: `<!DOCTYPE html>` at the top of this file. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org