[myfaces-tobago] branch master updated: ts-refactoring: tobago-header, tobago-footer: custom elements

[lo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

lofwyr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git


The following commit(s) were added to refs/heads/master by this push:
     new 9cab5d5  ts-refactoring: tobago-header, tobago-footer: custom elements
9cab5d5 is described below

commit 9cab5d5984f84da0436897e6d152879492dc36fb
Author: Udo Schnurpfeil <ud...@irian.eu>
AuthorDate: Fri Jul 10 09:59:38 2020 +0200

    ts-refactoring: tobago-header, tobago-footer: custom elements
    
    * removing .tobago-header and .tobago-footer (replaced by the tags)
    
    issue: TOBAGO-1633
---
 .../myfaces/tobago/internal/renderkit/renderer/FooterRenderer.java    | 3 ---
 .../myfaces/tobago/internal/renderkit/renderer/HeaderRenderer.java    | 3 ---
 .../java/org/apache/myfaces/tobago/renderkit/css/TobagoClass.java     | 2 --
 tobago-core/src/main/resources/scss/_tobago.scss                      | 4 ++--
 .../tobago-theme-speyside/src/main/scss/_speyside-overwrites.scss     | 3 ---
 5 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/FooterRenderer.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/FooterRenderer.java
index b326abd..4dd6cc4 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/FooterRenderer.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/FooterRenderer.java
@@ -24,7 +24,6 @@ import org.apache.myfaces.tobago.internal.component.AbstractUIFooter;
 import org.apache.myfaces.tobago.internal.util.HtmlRendererUtils;
 import org.apache.myfaces.tobago.renderkit.RendererBase;
 import org.apache.myfaces.tobago.renderkit.css.BootstrapClass;
-import org.apache.myfaces.tobago.renderkit.css.TobagoClass;
 import org.apache.myfaces.tobago.renderkit.html.HtmlAttributes;
 import org.apache.myfaces.tobago.renderkit.html.HtmlElements;
 import org.apache.myfaces.tobago.renderkit.html.HtmlRoleValues;
@@ -45,8 +44,6 @@ public class FooterRenderer extends RendererBase {
     writer.writeIdAttribute(component.getClientId(facesContext));
 
     writer.writeClassAttribute(
-        TobagoClass.FOOTER,
-        TobagoClass.FOOTER.createMarkup(markup),
         footer.isFixed() ? BootstrapClass.FIXED_BOTTOM : null,
         footer.getCustomClass());
     writer.writeAttribute(HtmlAttributes.ROLE, HtmlRoleValues.CONTENTINFO.toString(), false);
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/HeaderRenderer.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/HeaderRenderer.java
index 441d8ac..c24247f 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/HeaderRenderer.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/HeaderRenderer.java
@@ -24,7 +24,6 @@ import org.apache.myfaces.tobago.internal.component.AbstractUIHeader;
 import org.apache.myfaces.tobago.internal.util.HtmlRendererUtils;
 import org.apache.myfaces.tobago.renderkit.RendererBase;
 import org.apache.myfaces.tobago.renderkit.css.BootstrapClass;
-import org.apache.myfaces.tobago.renderkit.css.TobagoClass;
 import org.apache.myfaces.tobago.renderkit.html.HtmlAttributes;
 import org.apache.myfaces.tobago.renderkit.html.HtmlElements;
 import org.apache.myfaces.tobago.renderkit.html.HtmlRoleValues;
@@ -47,8 +46,6 @@ public class HeaderRenderer extends RendererBase {
     // TBD: how to configure it when it is needed, with customClass, or with markup?
 
     writer.writeClassAttribute(
-        TobagoClass.HEADER,
-        TobagoClass.HEADER.createMarkup(markup),
         header.isFixed() ? BootstrapClass.STICKY_TOP : null,
         header.getCustomClass());
 // TBD: should NAVBAR class be in the LinksRenderer?
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/renderkit/css/TobagoClass.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/renderkit/css/TobagoClass.java
index 866d182..ce13a34 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/renderkit/css/TobagoClass.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/renderkit/css/TobagoClass.java
@@ -133,10 +133,8 @@ public enum TobagoClass implements CssItem {
   FLEX_LAYOUT("tobago-flexLayout"),
   FLOW_LAYOUT("tobago-flowLayout"),
   FIGURE("tobago-figure"),
-  FOOTER("tobago-footer"),
   FORM("tobago-form"),
   GRID_LAYOUT("tobago-gridLayout"),
-  HEADER("tobago-header"),
   /**
    * @deprecated Since 5.0.0. Please use {@link TobagoClass#POPOVER__BUTTON}
    */
diff --git a/tobago-core/src/main/resources/scss/_tobago.scss b/tobago-core/src/main/resources/scss/_tobago.scss
index 2fdb039..3ad44aa 100644
--- a/tobago-core/src/main/resources/scss/_tobago.scss
+++ b/tobago-core/src/main/resources/scss/_tobago.scss
@@ -337,7 +337,7 @@ tobago-footer {
   display: block;
 }
 
-.tobago-footer {
+tobago-footer {
   background-color: #ffffff;
   padding: 5px 10px;
   box-shadow: 0 0 5px 5px rgba(200, 200, 200, 0.5);
@@ -374,7 +374,7 @@ tobago-header {
   display: block;
 }
 
-.tobago-header {
+tobago-header {
   margin-bottom: 1rem;
 
   &.sticky-top {
diff --git a/tobago-theme/tobago-theme-speyside/src/main/scss/_speyside-overwrites.scss b/tobago-theme/tobago-theme-speyside/src/main/scss/_speyside-overwrites.scss
index 378b2d4..3f9c60a 100644
--- a/tobago-theme/tobago-theme-speyside/src/main/scss/_speyside-overwrites.scss
+++ b/tobago-theme/tobago-theme-speyside/src/main/scss/_speyside-overwrites.scss
@@ -649,9 +649,6 @@ tobago-tab.tobago-tab-barFacet {
   }
 }
 
-.tobago-footer {
-}
-
 .table {
   .checkbox {
     margin-bottom: initial;