You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2022/08/21 20:47:19 UTC

[GitHub] [cxf] reta commented on a diff in pull request #992: Cxf 8710

reta commented on code in PR #992:
URL: https://github.com/apache/cxf/pull/992#discussion_r950898175


##########
rt/rs/description-swagger-ui/src/main/java/org/apache/cxf/jaxrs/swagger/ui/SwaggerUiConfig.java:
##########
@@ -260,6 +261,10 @@ public SwaggerUiConfig tryItOutEnabled(boolean tryItOut) {
     }
 
     public Boolean isQueryConfigEnabled() {
+        if (!Boolean.TRUE.equals(queryConfigEnabled) && !getConfigParameters().isEmpty()) {

Review Comment:
   @awrb this is a getter, which is not supposed to modify any other field, the `queryConfigEnabled` is 3 state property: `null`, `true`, `false`. We should only change this property implicitly when its value is not provided (means, it is `null`). If it is set to `true` or `false` already, we have to respect that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org