[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2560: [NETBEANS-5057] improved help on JSF composite component attributes

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #2560:
URL: https://github.com/apache/netbeans/pull/2560#discussion_r531208736



##########
File path: enterprise/web.jsf.editor/src/org/netbeans/modules/web/jsf/editor/facelets/CompositeComponentLibrary.java
##########
@@ -250,9 +250,11 @@ private synchronized void load() {
                 for (Map<String, String> attrsMap : model.getExistingInterfaceAttributes()) {
                     String attrname = attrsMap.get("name"); //NOI18N
                     boolean required = Boolean.parseBoolean(attrsMap.get("required")); //NOI18N
-                    String attributeDescription = getAttributesDescription(model, true);
+                    String attributeDescription = attrsMap.get("shortDescription"); //NOI18N

Review comment:
       Could you please describe what this change means? A visualization would be helpful.

##########
File path: enterprise/web.jsf.editor/src/org/netbeans/modules/web/jsf/editor/completion/JsfCompletionItem.java
##########
@@ -260,6 +260,11 @@ private String getHelpContent() {
             sb.append("<h1>"); //NOI18N
             sb.append(attr.getName());
             sb.append("</h1>"); //NOI18N
+            if (attr.getType() != null) {
+                sb.append("<div><b>Type:</b> "); //NOI18N

Review comment:
       The NOI18N is not totally correct here. it is  valid for the html tags, but not the text itself. Please move the text "Type" to "Bundle.properties". See "MSG_RequiredAttribute" and "MSG_NoAttributeDescription" below. 
   
   I just realised, that in line 257 the same issue is already present. It would be great, if you could also fix 257.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists