You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ma...@apache.org on 2017/09/29 07:22:05 UTC

[27/31] james-project git commit: MAILBOX-307 Remove test violating cross layer testing in Cassandra ACL testing

MAILBOX-307 Remove test violating cross layer testing in Cassandra ACL testing

This test is handled at the Mapper layer by 'addACLWhenNoneStoredShouldReturnUpdatedACL', which leads to more stable testing.


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/43887f44
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/43887f44
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/43887f44

Branch: refs/heads/master
Commit: 43887f44732b1d282963f2098c44fcdbf9b19b48
Parents: 183a372
Author: benwa <bt...@linagora.com>
Authored: Thu Sep 28 13:48:48 2017 +0700
Committer: Matthieu Baechler <ma...@apache.org>
Committed: Fri Sep 29 09:20:41 2017 +0200

----------------------------------------------------------------------
 .../cassandra/mail/CassandraACLMapperTest.java      | 16 ----------------
 1 file changed, 16 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/james-project/blob/43887f44/mailbox/cassandra/src/test/java/org/apache/james/mailbox/cassandra/mail/CassandraACLMapperTest.java
----------------------------------------------------------------------
diff --git a/mailbox/cassandra/src/test/java/org/apache/james/mailbox/cassandra/mail/CassandraACLMapperTest.java b/mailbox/cassandra/src/test/java/org/apache/james/mailbox/cassandra/mail/CassandraACLMapperTest.java
index 2439316..063651c 100644
--- a/mailbox/cassandra/src/test/java/org/apache/james/mailbox/cassandra/mail/CassandraACLMapperTest.java
+++ b/mailbox/cassandra/src/test/java/org/apache/james/mailbox/cassandra/mail/CassandraACLMapperTest.java
@@ -68,22 +68,6 @@ public class CassandraACLMapperTest {
     }
 
     @Test
-    public void retrieveACLWhenPresentInBaseShouldReturnCorrespondingACL() throws Exception {
-        cassandra.getConf().execute(
-            insertInto(CassandraACLTable.TABLE_NAME)
-                .value(CassandraACLTable.ID, MAILBOX_ID.asUuid())
-                .value(CassandraACLTable.ACL, "{\"entries\":{\"bob\":64}}")
-                .value(CassandraACLTable.VERSION, 1));
-
-        assertThat(cassandraACLMapper.getACL(MAILBOX_ID).join())
-            .isEqualTo(
-                MailboxACL.EMPTY.union(
-                    new MailboxACL.EntryKey("bob", MailboxACL.NameType.user, false),
-                    new MailboxACL.Rfc4314Rights(MailboxACL.Right.Read))
-            );
-    }
-
-    @Test
     public void retrieveACLWhenInvalidInBaseShouldReturnEmptyACL() throws Exception {
         cassandra.getConf().execute(
             insertInto(CassandraACLTable.TABLE_NAME)


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org