You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "bobhan1 (via GitHub)" <gi...@apache.org> on 2025/10/11 02:31:54 UTC

[PR] [Opt](sys table) Add a system table column_data_sizes [doris]

bobhan1 opened a new pull request, #56815:
URL: https://github.com/apache/doris/pull/56815

   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3406248949

   # BE UT Coverage Report
   Increment line coverage `20.98% (86/410)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/75c443a9ece75a41156ef8852eacc369c5fb1381_75c443a9ece75a41156ef8852eacc369c5fb1381/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/75c443a9ece75a41156ef8852eacc369c5fb1381_75c443a9ece75a41156ef8852eacc369c5fb1381/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.55% (17802/33874) |
   | Line Coverage     | 37.74% (161742/428519) |
   | Region Coverage   | 32.18% (123255/382961) |
   | Branch Coverage   | 33.61% (54153/161130) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3406065717

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/75c443a9ece75a41156ef8852eacc369c5fb1381_75c443a9ece75a41156ef8852eacc369c5fb1381_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/75c443a9ece75a41156ef8852eacc369c5fb1381_75c443a9ece75a41156ef8852eacc369c5fb1381_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 83.27% (1638/1967) |
   | Line Coverage     | 67.92% (28958/42638) |
   | Region Coverage   | 68.13% (14264/20937) |
   | Branch Coverage   | 58.39% (7589/12996) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3401504904

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/ffe2a83fc8e996112630acb8adb17a81450144e7_ffe2a83fc8e996112630acb8adb17a81450144e7_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/ffe2a83fc8e996112630acb8adb17a81450144e7_ffe2a83fc8e996112630acb8adb17a81450144e7_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 83.26% (1636/1965) |
   | Line Coverage     | 67.74% (28896/42660) |
   | Region Coverage   | 68.02% (14243/20939) |
   | Branch Coverage   | 58.30% (7580/13002) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3393041336

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3405243873

   Please add documentation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3402668438

   # FE Regression Coverage Report
   Increment line coverage `  100.00% (13/13)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/56815_ffe2a83fc8e996112630acb8adb17a81450144e7_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/56815_ffe2a83fc8e996112630acb8adb17a81450144e7_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on code in PR #56815:
URL: https://github.com/apache/doris/pull/56815#discussion_r2422628173


##########
regression-test/suites/query_p0/system/test_query_sys_column_data_sizes.groovy:
##########
@@ -0,0 +1,120 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_query_sys_column_data_sizes", "query,p0") {
+    def tableName = "test_column_data_sizes_table"
+
+    qt_desc_column_data_sizes """ DESC information_schema.column_data_sizes """
+
+    sql "DROP TABLE IF EXISTS ${tableName};"
+    sql """
+        CREATE TABLE ${tableName} (
+            id INT NOT NULL,
+            name VARCHAR(100),
+            age TINYINT,
+            salary DECIMAL(10, 2),
+            is_active BOOLEAN,
+            birth_date DATE,
+            create_time DATETIME,
+            score DOUBLE,
+            description TEXT,
+            amount BIGINT,
+            tags ARRAY<VARCHAR(50)>,
+            scores_map MAP<VARCHAR(20), INT>,
+            person_info STRUCT<address:VARCHAR(200), phone:VARCHAR(20), email:VARCHAR(100)>
+        )
+        DUPLICATE KEY(id)
+        DISTRIBUTED BY HASH(id) BUCKETS 1
+        PROPERTIES (
+            "replication_num" = "1",
+            "disable_auto_compaction" = "true"
+        )
+    """
+
+    sql """
+        INSERT INTO ${tableName} VALUES
+        (1, 'Alice', 25, 50000.50, true, '1998-01-15', '2024-01-01 10:00:00', 95.5, 'First employee', 1000000,
+         ['java', 'python', 'sql'], {'math':95, 'english':88}, named_struct('address', '123 Main St', 'phone', '1234567890', 'email', 'alice@example.com')),
+        (2, 'Bob', 30, 60000.75, true, '1993-05-20', '2024-01-02 11:00:00', 88.0, 'Second employee', 2000000,
+         ['c++', 'go'], {'math':90, 'physics':85}, named_struct('address', '456 Oak Ave', 'phone', '0987654321', 'email', 'bob@example.com')),
+        (3, 'Charlie', 28, 55000.25, false, '1995-08-10', '2024-01-03 12:00:00', 92.3, 'Third employee', 1500000,
+         ['javascript', 'typescript', 'react'], {'math':92, 'english':87, 'history':90}, named_struct('address', '789 Pine Rd', 'phone', '5551234567', 'email', 'charlie@example.com'))
+    """
+
+    sql """
+        INSERT INTO ${tableName} VALUES
+        (4, 'David', 35, 70000.00, true, '1988-11-25', '2024-01-04 13:00:00', 90.0, 'Fourth employee with a longer description text', 3000000,
+         ['rust', 'scala', 'haskell'], {'math':88, 'physics':92}, named_struct('address', '321 Elm St', 'phone', '1112223333', 'email', 'david@example.com')),
+        (5, 'Eve', 27, 52000.50, false, '1996-03-12', '2024-01-05 14:00:00', 87.5, 'Fifth employee', 1800000,
+         ['kotlin', 'swift'], {'math':85, 'chemistry':89}, named_struct('address', '654 Maple Dr', 'phone', '4445556666', 'email', 'eve@example.com'))
+    """
+
+    sql """
+        INSERT INTO ${tableName} VALUES
+        (6, 'Frank', 32, 65000.00, true, '1991-07-08', '2024-01-06 15:00:00', 91.2, 'Sixth employee', 2500000,
+         ['ruby', 'perl', 'php'], {'math':91, 'english':89}, named_struct('address', '987 Cedar Ln', 'phone', '7778889999', 'email', 'frank@example.com')),
+        (7, 'Grace', 29, 58000.75, true, '1994-12-30', '2024-01-07 16:00:00', 93.8, 'Seventh employee', 2200000,
+         ['r', 'matlab', 'julia'], {'math':94, 'statistics':96}, named_struct('address', '159 Birch Ct', 'phone', '2223334444', 'email', 'grace@example.com'))
+    """
+
+    // Get tablet ID for the test table
+    List<List<Object>> tablets = sql """ SHOW TABLETS FROM ${tableName} """
+    assert tablets.size() > 0, "Should have at least one tablet"
+    def tabletId = tablets[0][0]
+
+    def result_before = sql """
+        SELECT
+            COLUMN_NAME,
+            COLUMN_TYPE,
+            COUNT(DISTINCT ROWSET_ID) as rowset_count,
+            SUM(DATA_PAGE_SIZE) as total_data_page_size
+        FROM information_schema.column_data_sizes
+        WHERE TABLET_ID = ${tabletId}
+        GROUP BY COLUMN_NAME, COLUMN_TYPE
+        ORDER BY COLUMN_NAME
+    """
+
+    logger.info("Column data sizes before compaction:")
+    for (row in result_before) {
+        logger.info("Column: ${row[0]}, Type: ${row[1]}, Rowset Count: ${row[2]}, Total Size: ${row[3]}")
+        assert row[3] > 0
+    }
+
+    assert result_before.size() == 13, "Should have 13 columns"
+
+    trigger_and_wait_compaction(tableName, "full")
+
+    def result_after = sql """
+        SELECT
+            COLUMN_NAME,
+            COLUMN_TYPE,
+            COUNT(DISTINCT ROWSET_ID) as rowset_count,
+            SUM(DATA_PAGE_SIZE) as total_data_page_size
+        FROM information_schema.column_data_sizes
+        WHERE TABLET_ID = ${tabletId}
+        GROUP BY COLUMN_NAME, COLUMN_TYPE
+        ORDER BY COLUMN_NAME
+    """
+
+    logger.info("Column data sizes after compaction:")
+    for (row in result_after) {
+        logger.info("Column: ${row[0]}, Type: ${row[1]}, Rowset Count: ${row[2]}, Total Size: ${row[3]}")
+        assert row[3] > 0
+    }
+
+    assert result_after.size() == 13, "Should still have 13 columns after compaction"
+}

Review Comment:
   add a case to check column_data_size has value after compaction, e.g. check it after a full compaction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3406146815

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.9 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 75c443a9ece75a41156ef8852eacc369c5fb1381, data reload: false
   
   query1	0.05	0.04	0.05
   query2	0.11	0.06	0.07
   query3	0.29	0.07	0.08
   query4	1.60	0.09	0.08
   query5	0.27	0.25	0.26
   query6	1.17	0.66	0.64
   query7	0.03	0.02	0.03
   query8	0.06	0.07	0.05
   query9	0.64	0.53	0.53
   query10	0.59	0.59	0.58
   query11	0.25	0.12	0.12
   query12	0.25	0.14	0.15
   query13	0.66	0.62	0.64
   query14	1.03	1.03	1.04
   query15	0.95	0.88	0.86
   query16	0.40	0.39	0.40
   query17	1.04	1.07	1.07
   query18	0.23	0.22	0.22
   query19	1.98	1.83	1.86
   query20	0.02	0.01	0.02
   query21	15.38	1.00	0.69
   query22	0.93	1.10	0.83
   query23	14.70	1.60	0.77
   query24	5.39	0.60	0.31
   query25	0.17	0.10	0.09
   query26	0.55	0.22	0.17
   query27	0.09	0.10	0.09
   query28	11.10	1.68	1.05
   query29	12.58	3.99	3.33
   query30	0.32	0.12	0.10
   query31	2.84	0.63	0.44
   query32	3.25	0.60	0.50
   query33	3.06	3.13	3.06
   query34	16.70	5.46	4.77
   query35	4.87	4.83	4.89
   query36	0.67	0.54	0.52
   query37	0.22	0.19	0.20
   query38	0.19	0.17	0.18
   query39	0.05	0.04	0.04
   query40	0.22	0.18	0.17
   query41	0.11	0.06	0.06
   query42	0.07	0.06	0.06
   query43	0.06	0.06	0.05
   Total cold run time: 105.14 s
   Total hot run time: 30.9 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3402001981

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 190342 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit ffe2a83fc8e996112630acb8adb17a81450144e7, data reload: false
   
   query1	1063	426	408	408
   query2	6550	1663	1726	1663
   query3	6753	218	219	218
   query4	26118	23800	23401	23401
   query5	5064	647	517	517
   query6	353	268	227	227
   query7	4658	499	301	301
   query8	310	294	265	265
   query9	8735	2587	2612	2587
   query10	537	366	295	295
   query11	15805	15094	14841	14841
   query12	188	125	117	117
   query13	1699	596	447	447
   query14	11607	9272	9336	9272
   query15	238	197	180	180
   query16	7856	719	562	562
   query17	2095	847	684	684
   query18	2274	459	377	377
   query19	301	224	202	202
   query20	144	136	135	135
   query21	225	151	122	122
   query22	4598	4821	4522	4522
   query23	35072	33883	33886	33883
   query24	8283	2499	2481	2481
   query25	581	545	490	490
   query26	1240	276	173	173
   query27	3209	529	370	370
   query28	4307	2191	2130	2130
   query29	766	601	469	469
   query30	298	222	194	194
   query31	879	802	735	735
   query32	81	73	69	69
   query33	573	424	322	322
   query34	794	849	520	520
   query35	792	837	792	792
   query36	967	1015	937	937
   query37	121	111	83	83
   query38	3628	3542	3549	3542
   query39	1473	1405	1428	1405
   query40	218	123	116	116
   query41	60	61	68	61
   query42	120	113	108	108
   query43	492	522	469	469
   query44	1323	827	828	827
   query45	177	177	187	177
   query46	829	1004	650	650
   query47	1758	1777	1722	1722
   query48	382	453	321	321
   query49	774	529	413	413
   query50	638	685	403	403
   query51	3878	3908	3935	3908
   query52	110	105	104	104
   query53	226	261	215	215
   query54	586	598	521	521
   query55	99	81	80	80
   query56	351	334	301	301
   query57	1173	1193	1144	1144
   query58	279	274	279	274
   query59	2578	2681	2565	2565
   query60	348	332	340	332
   query61	147	155	155	155
   query62	817	724	672	672
   query63	227	198	191	191
   query64	4386	1175	826	826
   query65	4044	3991	3971	3971
   query66	1054	434	342	342
   query67	15497	15232	14977	14977
   query68	8821	910	598	598
   query69	475	325	284	284
   query70	1361	1280	1232	1232
   query71	502	341	315	315
   query72	5974	4879	4827	4827
   query73	560	590	356	356
   query74	8998	9059	9086	9059
   query75	4212	3386	2818	2818
   query76	3745	1169	796	796
   query77	961	413	312	312
   query78	9536	9918	8846	8846
   query79	3087	814	595	595
   query80	709	567	504	504
   query81	506	263	225	225
   query82	493	162	140	140
   query83	300	278	263	263
   query84	294	108	99	99
   query85	877	549	443	443
   query86	347	319	291	291
   query87	3792	3751	3625	3625
   query88	2918	2312	2242	2242
   query89	437	320	310	310
   query90	2003	216	212	212
   query91	163	241	133	133
   query92	86	71	75	71
   query93	2082	977	634	634
   query94	693	459	347	347
   query95	393	321	318	318
   query96	492	577	281	281
   query97	2938	2958	2884	2884
   query98	246	214	211	211
   query99	1462	1412	1288	1288
   Total cold run time: 282269 ms
   Total hot run time: 190342 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3405211008

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/30d45b2baf797104b9e00fe8e2a8bdbd04d7cc49_30d45b2baf797104b9e00fe8e2a8bdbd04d7cc49_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/30d45b2baf797104b9e00fe8e2a8bdbd04d7cc49_30d45b2baf797104b9e00fe8e2a8bdbd04d7cc49_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 83.27% (1638/1967) |
   | Line Coverage     | 67.84% (28926/42638) |
   | Region Coverage   | 68.11% (14260/20937) |
   | Branch Coverage   | 58.39% (7588/12996) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3405885973

   # BE UT Coverage Report
   Increment line coverage `20.98% (86/410)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/30d45b2baf797104b9e00fe8e2a8bdbd04d7cc49_30d45b2baf797104b9e00fe8e2a8bdbd04d7cc49/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/30d45b2baf797104b9e00fe8e2a8bdbd04d7cc49_30d45b2baf797104b9e00fe8e2a8bdbd04d7cc49/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.55% (17802/33874) |
   | Line Coverage     | 37.75% (161760/428530) |
   | Region Coverage   | 32.21% (123369/382969) |
   | Branch Coverage   | 33.61% (54162/161134) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3401405490

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3405377922

   # FE UT Coverage Report
   Increment line coverage `  100.00% (16/16)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/56815_30d45b2baf797104b9e00fe8e2a8bdbd04d7cc49/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/56815_30d45b2baf797104b9e00fe8e2a8bdbd04d7cc49/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #56815:
URL: https://github.com/apache/doris/pull/56815


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3405091731

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3407431314

   # FE Regression Coverage Report
   Increment line coverage `  100.00% (16/16)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/56815_75c443a9ece75a41156ef8852eacc369c5fb1381_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/56815_75c443a9ece75a41156ef8852eacc369c5fb1381_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3401647331

   # FE UT Coverage Report
   Increment line coverage `  100.00% (13/13)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/56815_ffe2a83fc8e996112630acb8adb17a81450144e7/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/56815_ffe2a83fc8e996112630acb8adb17a81450144e7/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3393213039

   # BE UT Coverage Report
   Increment line coverage `19.16% (55/287)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/28c7217202ffac9b14fe35d5e56720532e59e41b_28c7217202ffac9b14fe35d5e56720532e59e41b/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/28c7217202ffac9b14fe35d5e56720532e59e41b_28c7217202ffac9b14fe35d5e56720532e59e41b/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.49% (17735/33787) |
   | Line Coverage     | 37.66% (160988/427436) |
   | Region Coverage   | 32.17% (122996/382333) |
   | Branch Coverage   | 33.54% (53910/160717) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3401981674

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3405964785

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3405622195

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.25 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 30d45b2baf797104b9e00fe8e2a8bdbd04d7cc49, data reload: false
   
   query1	0.05	0.05	0.05
   query2	0.12	0.06	0.06
   query3	0.30	0.07	0.07
   query4	1.60	0.10	0.09
   query5	0.26	0.26	0.24
   query6	1.18	0.66	0.64
   query7	0.03	0.02	0.02
   query8	0.07	0.05	0.06
   query9	0.66	0.52	0.52
   query10	0.59	0.60	0.58
   query11	0.26	0.13	0.12
   query12	0.26	0.14	0.14
   query13	0.66	0.64	0.63
   query14	1.05	1.07	1.07
   query15	0.96	0.88	0.87
   query16	0.40	0.39	0.39
   query17	1.03	1.05	1.06
   query18	0.24	0.22	0.22
   query19	2.01	1.81	1.82
   query20	0.02	0.02	0.01
   query21	15.39	1.01	0.70
   query22	0.94	1.14	0.87
   query23	14.71	1.56	0.76
   query24	5.31	0.67	0.34
   query25	0.18	0.09	0.09
   query26	0.54	0.23	0.18
   query27	0.09	0.09	0.09
   query28	11.10	1.67	1.05
   query29	12.54	4.12	3.40
   query30	0.31	0.12	0.12
   query31	2.81	0.63	0.44
   query32	3.25	0.61	0.51
   query33	3.12	3.19	3.10
   query34	16.64	5.54	4.81
   query35	4.86	4.89	4.88
   query36	0.66	0.53	0.55
   query37	0.22	0.19	0.20
   query38	0.18	0.18	0.18
   query39	0.06	0.05	0.05
   query40	0.20	0.17	0.17
   query41	0.12	0.06	0.05
   query42	0.06	0.05	0.06
   query43	0.06	0.06	0.06
   Total cold run time: 105.1 s
   Total hot run time: 31.25 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on code in PR #56815:
URL: https://github.com/apache/doris/pull/56815#discussion_r2422631599


##########
regression-test/suites/query_p0/system/test_query_sys_column_data_sizes.groovy:
##########
@@ -0,0 +1,120 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_query_sys_column_data_sizes", "query,p0") {
+    def tableName = "test_column_data_sizes_table"
+
+    qt_desc_column_data_sizes """ DESC information_schema.column_data_sizes """
+
+    sql "DROP TABLE IF EXISTS ${tableName};"
+    sql """
+        CREATE TABLE ${tableName} (
+            id INT NOT NULL,
+            name VARCHAR(100),
+            age TINYINT,
+            salary DECIMAL(10, 2),
+            is_active BOOLEAN,
+            birth_date DATE,
+            create_time DATETIME,
+            score DOUBLE,
+            description TEXT,
+            amount BIGINT,
+            tags ARRAY<VARCHAR(50)>,
+            scores_map MAP<VARCHAR(20), INT>,
+            person_info STRUCT<address:VARCHAR(200), phone:VARCHAR(20), email:VARCHAR(100)>
+        )
+        DUPLICATE KEY(id)
+        DISTRIBUTED BY HASH(id) BUCKETS 1
+        PROPERTIES (
+            "replication_num" = "1",
+            "disable_auto_compaction" = "true"
+        )
+    """
+
+    sql """
+        INSERT INTO ${tableName} VALUES
+        (1, 'Alice', 25, 50000.50, true, '1998-01-15', '2024-01-01 10:00:00', 95.5, 'First employee', 1000000,
+         ['java', 'python', 'sql'], {'math':95, 'english':88}, named_struct('address', '123 Main St', 'phone', '1234567890', 'email', 'alice@example.com')),
+        (2, 'Bob', 30, 60000.75, true, '1993-05-20', '2024-01-02 11:00:00', 88.0, 'Second employee', 2000000,
+         ['c++', 'go'], {'math':90, 'physics':85}, named_struct('address', '456 Oak Ave', 'phone', '0987654321', 'email', 'bob@example.com')),
+        (3, 'Charlie', 28, 55000.25, false, '1995-08-10', '2024-01-03 12:00:00', 92.3, 'Third employee', 1500000,
+         ['javascript', 'typescript', 'react'], {'math':92, 'english':87, 'history':90}, named_struct('address', '789 Pine Rd', 'phone', '5551234567', 'email', 'charlie@example.com'))
+    """
+
+    sql """
+        INSERT INTO ${tableName} VALUES
+        (4, 'David', 35, 70000.00, true, '1988-11-25', '2024-01-04 13:00:00', 90.0, 'Fourth employee with a longer description text', 3000000,
+         ['rust', 'scala', 'haskell'], {'math':88, 'physics':92}, named_struct('address', '321 Elm St', 'phone', '1112223333', 'email', 'david@example.com')),
+        (5, 'Eve', 27, 52000.50, false, '1996-03-12', '2024-01-05 14:00:00', 87.5, 'Fifth employee', 1800000,
+         ['kotlin', 'swift'], {'math':85, 'chemistry':89}, named_struct('address', '654 Maple Dr', 'phone', '4445556666', 'email', 'eve@example.com'))
+    """
+
+    sql """
+        INSERT INTO ${tableName} VALUES
+        (6, 'Frank', 32, 65000.00, true, '1991-07-08', '2024-01-06 15:00:00', 91.2, 'Sixth employee', 2500000,
+         ['ruby', 'perl', 'php'], {'math':91, 'english':89}, named_struct('address', '987 Cedar Ln', 'phone', '7778889999', 'email', 'frank@example.com')),
+        (7, 'Grace', 29, 58000.75, true, '1994-12-30', '2024-01-07 16:00:00', 93.8, 'Seventh employee', 2200000,
+         ['r', 'matlab', 'julia'], {'math':94, 'statistics':96}, named_struct('address', '159 Birch Ct', 'phone', '2223334444', 'email', 'grace@example.com'))
+    """
+
+    // Get tablet ID for the test table
+    List<List<Object>> tablets = sql """ SHOW TABLETS FROM ${tableName} """
+    assert tablets.size() > 0, "Should have at least one tablet"
+    def tabletId = tablets[0][0]
+
+    def result_before = sql """
+        SELECT
+            COLUMN_NAME,
+            COLUMN_TYPE,
+            COUNT(DISTINCT ROWSET_ID) as rowset_count,
+            SUM(DATA_PAGE_SIZE) as total_data_page_size
+        FROM information_schema.column_data_sizes
+        WHERE TABLET_ID = ${tabletId}
+        GROUP BY COLUMN_NAME, COLUMN_TYPE
+        ORDER BY COLUMN_NAME
+    """
+
+    logger.info("Column data sizes before compaction:")
+    for (row in result_before) {
+        logger.info("Column: ${row[0]}, Type: ${row[1]}, Rowset Count: ${row[2]}, Total Size: ${row[3]}")
+        assert row[3] > 0
+    }
+
+    assert result_before.size() == 13, "Should have 13 columns"
+
+    trigger_and_wait_compaction(tableName, "full")
+
+    def result_after = sql """
+        SELECT
+            COLUMN_NAME,
+            COLUMN_TYPE,
+            COUNT(DISTINCT ROWSET_ID) as rowset_count,
+            SUM(DATA_PAGE_SIZE) as total_data_page_size
+        FROM information_schema.column_data_sizes
+        WHERE TABLET_ID = ${tabletId}
+        GROUP BY COLUMN_NAME, COLUMN_TYPE
+        ORDER BY COLUMN_NAME
+    """
+
+    logger.info("Column data sizes after compaction:")
+    for (row in result_after) {
+        logger.info("Column: ${row[0]}, Type: ${row[1]}, Rowset Count: ${row[2]}, Total Size: ${row[3]}")
+        assert row[3] > 0
+    }
+
+    assert result_after.size() == 13, "Should still have 13 columns after compaction"
+}

Review Comment:
   has been checked



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on code in PR #56815:
URL: https://github.com/apache/doris/pull/56815#discussion_r2425496375


##########
regression-test/data/query_p0/system/test_query_sys_column_data_sizes.out:
##########
@@ -0,0 +1,11 @@
+-- This file is automatically generated. You should know what you did if you want to edit this
+-- !desc_column_data_sizes --
+BACKEND_ID	bigint	Yes	false	\N	
+TABLE_ID	bigint	Yes	false	\N	
+ROWSET_ID	varchar(64)	Yes	false	\N	
+TABLET_ID	bigint	Yes	false	\N	
+COLUMN_UNIQUE_ID	int	Yes	false	\N	
+COLUMN_NAME	varchar(64)	Yes	false	\N	
+COLUMN_TYPE	varchar(64)	Yes	false	\N	
+COMPRESSED_DATA_SIZE	bigint	Yes	false	\N	

Review Comment:
   data_bytes is better than data_size.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3392783664

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3407381527

   # BE Regression && UT Coverage Report
   Increment line coverage `90.00% (369/410)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/56815_75c443a9ece75a41156ef8852eacc369c5fb1381_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/56815_75c443a9ece75a41156ef8852eacc369c5fb1381_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 71.24% (23656/33206) |
   | Line Coverage     | 57.67% (246985/428262) |
   | Region Coverage   | 52.62% (204117/387908) |
   | Branch Coverage   | 54.50% (88299/162019) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3408881491

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3402026445

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.06 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit ffe2a83fc8e996112630acb8adb17a81450144e7, data reload: false
   
   query1	0.05	0.05	0.04
   query2	0.12	0.06	0.05
   query3	0.31	0.07	0.07
   query4	1.62	0.09	0.09
   query5	0.27	0.25	0.25
   query6	1.18	0.65	0.64
   query7	0.04	0.03	0.03
   query8	0.07	0.06	0.06
   query9	0.65	0.54	0.53
   query10	0.59	0.61	0.59
   query11	0.25	0.13	0.13
   query12	0.25	0.13	0.14
   query13	0.63	0.64	0.64
   query14	1.04	1.04	1.06
   query15	0.96	0.86	0.87
   query16	0.39	0.39	0.39
   query17	1.03	1.10	1.07
   query18	0.23	0.23	0.22
   query19	1.98	1.86	1.80
   query20	0.01	0.02	0.02
   query21	15.39	1.00	0.70
   query22	0.93	1.02	0.80
   query23	14.74	1.54	0.78
   query24	5.02	0.68	0.34
   query25	0.17	0.09	0.09
   query26	0.56	0.22	0.18
   query27	0.09	0.09	0.10
   query28	11.05	1.61	1.04
   query29	12.59	4.04	3.37
   query30	0.32	0.12	0.10
   query31	2.82	0.64	0.42
   query32	3.24	0.60	0.52
   query33	3.14	3.16	3.20
   query34	17.12	5.50	4.78
   query35	4.89	4.78	4.84
   query36	0.65	0.52	0.51
   query37	0.23	0.19	0.19
   query38	0.20	0.18	0.18
   query39	0.06	0.05	0.05
   query40	0.21	0.16	0.18
   query41	0.12	0.06	0.06
   query42	0.07	0.06	0.07
   query43	0.06	0.05	0.05
   Total cold run time: 105.34 s
   Total hot run time: 31.06 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3401981848

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3405244538

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](sys table) Add a system table column_data_sizes [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56815:
URL: https://github.com/apache/doris/pull/56815#issuecomment-3393063161

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/28c7217202ffac9b14fe35d5e56720532e59e41b_28c7217202ffac9b14fe35d5e56720532e59e41b_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/28c7217202ffac9b14fe35d5e56720532e59e41b_28c7217202ffac9b14fe35d5e56720532e59e41b_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 83.38% (1635/1961) |
   | Line Coverage     | 67.87% (28898/42578) |
   | Region Coverage   | 68.07% (14234/20911) |
   | Branch Coverage   | 58.38% (7579/12982) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org