You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by xt...@apache.org on 2024/05/23 08:10:30 UTC
(flink) 06/08: [FLINK-35359][runtime] Remove logic to instantiate BlockCompressionFactory from user-defined class name
This is an automated email from the ASF dual-hosted git repository.
xtsong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 58f08139708ea8a93225cd0f81fc849137ee194e
Author: sxnan <su...@gmail.com>
AuthorDate: Thu May 23 11:54:18 2024 +0800
[FLINK-35359][runtime] Remove logic to instantiate BlockCompressionFactory from user-defined class name
There are no use internally to instantiate the BlockCompressionFactory from class name. Even though, it is possible for user to pass a user-defined class name to BlockCompressionFactory, this ability is never exposed in any public documentation.
---
.../io/compression/BlockCompressionFactory.java | 62 ++++++----------------
1 file changed, 17 insertions(+), 45 deletions(-)
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/io/compression/BlockCompressionFactory.java b/flink-runtime/src/main/java/org/apache/flink/runtime/io/compression/BlockCompressionFactory.java
index 145578e036f..5cbef9527ba 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/io/compression/BlockCompressionFactory.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/io/compression/BlockCompressionFactory.java
@@ -18,8 +18,6 @@
package org.apache.flink.runtime.io.compression;
-import org.apache.flink.configuration.IllegalConfigurationException;
-
import io.airlift.compress.lzo.LzoCompressor;
import io.airlift.compress.lzo.LzoDecompressor;
import io.airlift.compress.zstd.ZstdCompressor;
@@ -47,58 +45,32 @@ public interface BlockCompressionFactory {
/**
* Creates {@link BlockCompressionFactory} according to the configuration.
*
- * @param compressionFactoryName supported compression codecs or user-defined class name
- * inherited from {@link BlockCompressionFactory}.
+ * @param compressionFactoryName supported compression codecs.
*/
static BlockCompressionFactory createBlockCompressionFactory(String compressionFactoryName) {
checkNotNull(compressionFactoryName);
- CompressionFactoryName compressionName;
- try {
- compressionName = CompressionFactoryName.valueOf(compressionFactoryName.toUpperCase());
- } catch (IllegalArgumentException e) {
- compressionName = null;
- }
+ CompressionFactoryName compressionName =
+ CompressionFactoryName.valueOf(compressionFactoryName.toUpperCase());
BlockCompressionFactory blockCompressionFactory;
- if (compressionName != null) {
- switch (compressionName) {
- case LZ4:
- blockCompressionFactory = new Lz4BlockCompressionFactory();
- break;
- case LZO:
- blockCompressionFactory =
- new AirCompressorFactory(new LzoCompressor(), new LzoDecompressor());
- break;
- case ZSTD:
- blockCompressionFactory =
- new AirCompressorFactory(new ZstdCompressor(), new ZstdDecompressor());
- break;
- default:
- throw new IllegalStateException("Unknown CompressionMethod " + compressionName);
- }
- } else {
- Object factoryObj;
- try {
- factoryObj = Class.forName(compressionFactoryName).newInstance();
- } catch (ClassNotFoundException e) {
- throw new IllegalConfigurationException(
- "Cannot load class " + compressionFactoryName, e);
- } catch (Exception e) {
- throw new IllegalConfigurationException(
- "Cannot create object for class " + compressionFactoryName, e);
- }
- if (factoryObj instanceof BlockCompressionFactory) {
- blockCompressionFactory = (BlockCompressionFactory) factoryObj;
- } else {
- throw new IllegalArgumentException(
- "CompressionFactoryName should inherit from"
- + " interface BlockCompressionFactory, or use the default compression codec.");
- }
+ switch (compressionName) {
+ case LZ4:
+ blockCompressionFactory = new Lz4BlockCompressionFactory();
+ break;
+ case LZO:
+ blockCompressionFactory =
+ new AirCompressorFactory(new LzoCompressor(), new LzoDecompressor());
+ break;
+ case ZSTD:
+ blockCompressionFactory =
+ new AirCompressorFactory(new ZstdCompressor(), new ZstdDecompressor());
+ break;
+ default:
+ throw new IllegalStateException("Unknown CompressionMethod " + compressionName);
}
- checkNotNull(blockCompressionFactory);
return blockCompressionFactory;
}
}