You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martijn Dashorst <ma...@gmail.com> on 2013/07/05 18:17:03 UTC
[VOTE] Release Apache Wicket 6.9.1 - fix for CDI issues
This is a vote to release Apache Wicket 6.9.1
This is a patch release for 6.9.0 because in 6.9.0 the CDI integration was
broken for injecting into anonymous inner classes (see WICKET-5226).
This release only contains (in addition to anything that was fixed in 6.9.0)
the reversal of the particular commit that caused WICKET-5226 to disable
injection into anonymous inner classes.
Please download the source distributions found in our staging area
linked below.
I have included the signatures for both the source archives. This vote
lasts for 72 hours minimum.
[ ] Yes, release Apache Wicket 6.9.1
[ ] No, don't release Apache Wicket 6.9.1, because ...
Distributions, changelog, keys and signatures can be found at:
https://dist.apache.org/repos/dist/dev/wicket/6.9.1
Staging repository:
https://repository.apache.org/content/repositories/orgapachewicket-106/
The binaries are available in the above link, as are a staging
repository for Maven. Typically the vote is on the source, but should
you find a problem with one of the binaries, please let me know, I can
re-roll them some way or the other.
Here are the signatures for the source release artifacts:
apache-wicket-6.9.1.tar.gz.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (Darwin)
iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXEmgCfSgYLE1GOcEKBhjk3O67vxB6K
d60AoJHM3P+7W+qUvGl1zLIv375FGNj8
=P14U
-----END PGP SIGNATURE-----
apache-wicket-6.9.1.zip.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (Darwin)
iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXdxQCfRqJKCVuIIVqTjssax5q1aNb7
Z5UAoJN196AuUUG1CYYNw+Lm1QSXv9Tc
=yHaF
-----END PGP SIGNATURE-----
Re: [VOTE] Release Apache Wicket 6.9.1 - fix for CDI issues
Posted by Martijn Dashorst <ma...@gmail.com>.
We figured that while the jquery upgrade is unfortunate, it is the way
of the future.
The announcement should have been more prominent (or rather included
at all). The issue is quite easy to work around.
Basically we should have discussed options more readily, and possibly
we'll do something for 6.10 or so to alleviate the issues with jquery
1.9+.
Martijn
On Fri, Jul 5, 2013 at 7:49 PM, Cedric Gatay <ga...@gmail.com> wrote:
> Seems to work ok for me in the biggest CDI enabled app I got (tested on
> Glassfish 3.1.2.2). To answer my previous question, jQuery version is 1.10.1
> So :
> [X] Yes, release Apache Wicket 6.9.1
>
> Regards,
>
> __
> Cedric Gatay (@Cedric_Gatay <http://twitter.com/Cedric_Gatay>)
> http://code-troopers.com | http://www.bloggure.info | http://cedric.gatay.fr
>
>
> On Fri, Jul 5, 2013 at 6:39 PM, Cedric Gatay <ga...@gmail.com> wrote:
>
>> Hi,
>>
>> Nothing has been changed regarding the jQuery issue discussed yesterday ?
>>
>> __
>> Cedric Gatay (@Cedric_Gatay <http://twitter.com/Cedric_Gatay>)
>> http://code-troopers.com | http://www.bloggure.info |
>> http://cedric.gatay.fr
>>
>>
>> On Fri, Jul 5, 2013 at 6:17 PM, Martijn Dashorst <
>> martijn.dashorst@gmail.com> wrote:
>>
>>> This is a vote to release Apache Wicket 6.9.1
>>>
>>> This is a patch release for 6.9.0 because in 6.9.0 the CDI integration was
>>> broken for injecting into anonymous inner classes (see WICKET-5226).
>>>
>>> This release only contains (in addition to anything that was fixed in
>>> 6.9.0)
>>> the reversal of the particular commit that caused WICKET-5226 to disable
>>> injection into anonymous inner classes.
>>>
>>> Please download the source distributions found in our staging area
>>> linked below.
>>>
>>> I have included the signatures for both the source archives. This vote
>>> lasts for 72 hours minimum.
>>>
>>> [ ] Yes, release Apache Wicket 6.9.1
>>> [ ] No, don't release Apache Wicket 6.9.1, because ...
>>>
>>> Distributions, changelog, keys and signatures can be found at:
>>>
>>> https://dist.apache.org/repos/dist/dev/wicket/6.9.1
>>>
>>> Staging repository:
>>>
>>>
>>> https://repository.apache.org/content/repositories/orgapachewicket-106/
>>>
>>> The binaries are available in the above link, as are a staging
>>> repository for Maven. Typically the vote is on the source, but should
>>> you find a problem with one of the binaries, please let me know, I can
>>> re-roll them some way or the other.
>>>
>>> Here are the signatures for the source release artifacts:
>>>
>>> apache-wicket-6.9.1.tar.gz.asc
>>> -----BEGIN PGP SIGNATURE-----
>>> Version: GnuPG v1.4.13 (Darwin)
>>>
>>> iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXEmgCfSgYLE1GOcEKBhjk3O67vxB6K
>>> d60AoJHM3P+7W+qUvGl1zLIv375FGNj8
>>> =P14U
>>> -----END PGP SIGNATURE-----
>>>
>>>
>>> apache-wicket-6.9.1.zip.asc
>>> -----BEGIN PGP SIGNATURE-----
>>> Version: GnuPG v1.4.13 (Darwin)
>>>
>>> iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXdxQCfRqJKCVuIIVqTjssax5q1aNb7
>>> Z5UAoJN196AuUUG1CYYNw+Lm1QSXv9Tc
>>> =yHaF
>>> -----END PGP SIGNATURE-----
>>>
>>
>>
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: [VOTE] Release Apache Wicket 6.9.1 - fix for CDI issues
Posted by Cedric Gatay <ga...@gmail.com>.
Seems to work ok for me in the biggest CDI enabled app I got (tested on
Glassfish 3.1.2.2). To answer my previous question, jQuery version is 1.10.1
So :
[X] Yes, release Apache Wicket 6.9.1
Regards,
__
Cedric Gatay (@Cedric_Gatay <http://twitter.com/Cedric_Gatay>)
http://code-troopers.com | http://www.bloggure.info | http://cedric.gatay.fr
On Fri, Jul 5, 2013 at 6:39 PM, Cedric Gatay <ga...@gmail.com> wrote:
> Hi,
>
> Nothing has been changed regarding the jQuery issue discussed yesterday ?
>
> __
> Cedric Gatay (@Cedric_Gatay <http://twitter.com/Cedric_Gatay>)
> http://code-troopers.com | http://www.bloggure.info |
> http://cedric.gatay.fr
>
>
> On Fri, Jul 5, 2013 at 6:17 PM, Martijn Dashorst <
> martijn.dashorst@gmail.com> wrote:
>
>> This is a vote to release Apache Wicket 6.9.1
>>
>> This is a patch release for 6.9.0 because in 6.9.0 the CDI integration was
>> broken for injecting into anonymous inner classes (see WICKET-5226).
>>
>> This release only contains (in addition to anything that was fixed in
>> 6.9.0)
>> the reversal of the particular commit that caused WICKET-5226 to disable
>> injection into anonymous inner classes.
>>
>> Please download the source distributions found in our staging area
>> linked below.
>>
>> I have included the signatures for both the source archives. This vote
>> lasts for 72 hours minimum.
>>
>> [ ] Yes, release Apache Wicket 6.9.1
>> [ ] No, don't release Apache Wicket 6.9.1, because ...
>>
>> Distributions, changelog, keys and signatures can be found at:
>>
>> https://dist.apache.org/repos/dist/dev/wicket/6.9.1
>>
>> Staging repository:
>>
>>
>> https://repository.apache.org/content/repositories/orgapachewicket-106/
>>
>> The binaries are available in the above link, as are a staging
>> repository for Maven. Typically the vote is on the source, but should
>> you find a problem with one of the binaries, please let me know, I can
>> re-roll them some way or the other.
>>
>> Here are the signatures for the source release artifacts:
>>
>> apache-wicket-6.9.1.tar.gz.asc
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.13 (Darwin)
>>
>> iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXEmgCfSgYLE1GOcEKBhjk3O67vxB6K
>> d60AoJHM3P+7W+qUvGl1zLIv375FGNj8
>> =P14U
>> -----END PGP SIGNATURE-----
>>
>>
>> apache-wicket-6.9.1.zip.asc
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.13 (Darwin)
>>
>> iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXdxQCfRqJKCVuIIVqTjssax5q1aNb7
>> Z5UAoJN196AuUUG1CYYNw+Lm1QSXv9Tc
>> =yHaF
>> -----END PGP SIGNATURE-----
>>
>
>
Re: [VOTE] Release Apache Wicket 6.9.1 - fix for CDI issues
Posted by Cedric Gatay <ga...@gmail.com>.
Hi,
Nothing has been changed regarding the jQuery issue discussed yesterday ?
__
Cedric Gatay (@Cedric_Gatay <http://twitter.com/Cedric_Gatay>)
http://code-troopers.com | http://www.bloggure.info | http://cedric.gatay.fr
On Fri, Jul 5, 2013 at 6:17 PM, Martijn Dashorst <martijn.dashorst@gmail.com
> wrote:
> This is a vote to release Apache Wicket 6.9.1
>
> This is a patch release for 6.9.0 because in 6.9.0 the CDI integration was
> broken for injecting into anonymous inner classes (see WICKET-5226).
>
> This release only contains (in addition to anything that was fixed in
> 6.9.0)
> the reversal of the particular commit that caused WICKET-5226 to disable
> injection into anonymous inner classes.
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 6.9.1
> [ ] No, don't release Apache Wicket 6.9.1, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
> https://dist.apache.org/repos/dist/dev/wicket/6.9.1
>
> Staging repository:
>
>
> https://repository.apache.org/content/repositories/orgapachewicket-106/
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> Here are the signatures for the source release artifacts:
>
> apache-wicket-6.9.1.tar.gz.asc
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.13 (Darwin)
>
> iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXEmgCfSgYLE1GOcEKBhjk3O67vxB6K
> d60AoJHM3P+7W+qUvGl1zLIv375FGNj8
> =P14U
> -----END PGP SIGNATURE-----
>
>
> apache-wicket-6.9.1.zip.asc
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.13 (Darwin)
>
> iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXdxQCfRqJKCVuIIVqTjssax5q1aNb7
> Z5UAoJN196AuUUG1CYYNw+Lm1QSXv9Tc
> =yHaF
> -----END PGP SIGNATURE-----
>
Re: [VOTE] Release Apache Wicket 6.9.1 - fix for CDI issues
Posted by Martijn Dashorst <ma...@gmail.com>.
+1
On Fri, Jul 5, 2013 at 6:17 PM, Martijn Dashorst
<ma...@gmail.com> wrote:
> This is a vote to release Apache Wicket 6.9.1
>
> This is a patch release for 6.9.0 because in 6.9.0 the CDI integration was
> broken for injecting into anonymous inner classes (see WICKET-5226).
>
> This release only contains (in addition to anything that was fixed in 6.9.0)
> the reversal of the particular commit that caused WICKET-5226 to disable
> injection into anonymous inner classes.
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 6.9.1
> [ ] No, don't release Apache Wicket 6.9.1, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
> https://dist.apache.org/repos/dist/dev/wicket/6.9.1
>
> Staging repository:
>
> https://repository.apache.org/content/repositories/orgapachewicket-106/
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> Here are the signatures for the source release artifacts:
>
> apache-wicket-6.9.1.tar.gz.asc
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.13 (Darwin)
>
> iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXEmgCfSgYLE1GOcEKBhjk3O67vxB6K
> d60AoJHM3P+7W+qUvGl1zLIv375FGNj8
> =P14U
> -----END PGP SIGNATURE-----
>
>
> apache-wicket-6.9.1.zip.asc
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.13 (Darwin)
>
> iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXdxQCfRqJKCVuIIVqTjssax5q1aNb7
> Z5UAoJN196AuUUG1CYYNw+Lm1QSXv9Tc
> =yHaF
> -----END PGP SIGNATURE-----
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: [VOTE] Release Apache Wicket 6.9.1 - fix for CDI issues
Posted by Martijn Dashorst <ma...@gmail.com>.
This vote passes, I'll start the promotion...
Martijn
On Fri, Jul 5, 2013 at 6:17 PM, Martijn Dashorst
<ma...@gmail.com> wrote:
> This is a vote to release Apache Wicket 6.9.1
>
> This is a patch release for 6.9.0 because in 6.9.0 the CDI integration was
> broken for injecting into anonymous inner classes (see WICKET-5226).
>
> This release only contains (in addition to anything that was fixed in 6.9.0)
> the reversal of the particular commit that caused WICKET-5226 to disable
> injection into anonymous inner classes.
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 6.9.1
> [ ] No, don't release Apache Wicket 6.9.1, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
> https://dist.apache.org/repos/dist/dev/wicket/6.9.1
>
> Staging repository:
>
> https://repository.apache.org/content/repositories/orgapachewicket-106/
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> Here are the signatures for the source release artifacts:
>
> apache-wicket-6.9.1.tar.gz.asc
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.13 (Darwin)
>
> iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXEmgCfSgYLE1GOcEKBhjk3O67vxB6K
> d60AoJHM3P+7W+qUvGl1zLIv375FGNj8
> =P14U
> -----END PGP SIGNATURE-----
>
>
> apache-wicket-6.9.1.zip.asc
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.13 (Darwin)
>
> iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXdxQCfRqJKCVuIIVqTjssax5q1aNb7
> Z5UAoJN196AuUUG1CYYNw+Lm1QSXv9Tc
> =yHaF
> -----END PGP SIGNATURE-----
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: [VOTE] Release Apache Wicket 6.9.1 - fix for CDI issues
Posted by Emond Papegaaij <em...@gmail.com>.
+1 to release
One minor issue: we should upgrade the versions of the experimental modules
because the versions got upgraded in 6.9.1. For example, wicket-6.x has
wicket-atmosphere-0.12-SNAPSHOT and wicket-6.9.1 contains 0.12.
Btw, can you add 6.9.1 to jira, so I can close the ticket as fixed in 6.9.1?
Emond
On Fri, Jul 5, 2013 at 6:17 PM, Martijn Dashorst <martijn.dashorst@gmail.com
> wrote:
> This is a vote to release Apache Wicket 6.9.1
>
> This is a patch release for 6.9.0 because in 6.9.0 the CDI integration was
> broken for injecting into anonymous inner classes (see WICKET-5226).
>
> This release only contains (in addition to anything that was fixed in
> 6.9.0)
> the reversal of the particular commit that caused WICKET-5226 to disable
> injection into anonymous inner classes.
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 6.9.1
> [ ] No, don't release Apache Wicket 6.9.1, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
> https://dist.apache.org/repos/dist/dev/wicket/6.9.1
>
> Staging repository:
>
>
> https://repository.apache.org/content/repositories/orgapachewicket-106/
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> Here are the signatures for the source release artifacts:
>
> apache-wicket-6.9.1.tar.gz.asc
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.13 (Darwin)
>
> iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXEmgCfSgYLE1GOcEKBhjk3O67vxB6K
> d60AoJHM3P+7W+qUvGl1zLIv375FGNj8
> =P14U
> -----END PGP SIGNATURE-----
>
>
> apache-wicket-6.9.1.zip.asc
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.13 (Darwin)
>
> iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXdxQCfRqJKCVuIIVqTjssax5q1aNb7
> Z5UAoJN196AuUUG1CYYNw+Lm1QSXv9Tc
> =yHaF
> -----END PGP SIGNATURE-----
>
Re: [VOTE] Release Apache Wicket 6.9.1 - fix for CDI issues
Posted by Igor Vaynberg <ig...@gmail.com>.
+1 to release
-igor
On Fri, Jul 5, 2013 at 9:17 AM, Martijn Dashorst
<ma...@gmail.com> wrote:
> This is a vote to release Apache Wicket 6.9.1
>
> This is a patch release for 6.9.0 because in 6.9.0 the CDI integration was
> broken for injecting into anonymous inner classes (see WICKET-5226).
>
> This release only contains (in addition to anything that was fixed in 6.9.0)
> the reversal of the particular commit that caused WICKET-5226 to disable
> injection into anonymous inner classes.
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 6.9.1
> [ ] No, don't release Apache Wicket 6.9.1, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
> https://dist.apache.org/repos/dist/dev/wicket/6.9.1
>
> Staging repository:
>
> https://repository.apache.org/content/repositories/orgapachewicket-106/
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> Here are the signatures for the source release artifacts:
>
> apache-wicket-6.9.1.tar.gz.asc
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.13 (Darwin)
>
> iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXEmgCfSgYLE1GOcEKBhjk3O67vxB6K
> d60AoJHM3P+7W+qUvGl1zLIv375FGNj8
> =P14U
> -----END PGP SIGNATURE-----
>
>
> apache-wicket-6.9.1.zip.asc
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.13 (Darwin)
>
> iEYEABECAAYFAlHW674ACgkQJBX8W/xy/UXdxQCfRqJKCVuIIVqTjssax5q1aNb7
> Z5UAoJN196AuUUG1CYYNw+Lm1QSXv9Tc
> =yHaF
> -----END PGP SIGNATURE-----