[GitHub] ivankelly commented on a change in pull request #785: Issue 784: LedgerEntries#close should not throw checked exception

[GitBox <gi...@apache.org>]

ivankelly commented on a change in pull request #785: Issue 784: LedgerEntries#close should not throw checked exception
URL: https://github.com/apache/bookkeeper/pull/785#discussion_r153731696
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java
 ##########
 @@ -42,10 +42,15 @@
      * Calling this method does not modify the reference count of the ByteBuf in the returned LedgerEntry objects.
      * The caller who calls {@link #iterator()} should make sure that they do not call ByteBuf.release() on the
      * LedgerEntry objects to avoid a double free.
-     * All reference counts will be decremented when the containing LedgerEntries object is closed.
+     * All reference counts will be decremented when the containing LedgerEntries object is closed via {@link #close()}.
      *
      * @return an iterator of LedgerEntry objects
      */
     @Override
     Iterator<LedgerEntry> iterator();
+
+    /**
+     * Close to release the resources held by this instance.
+     */
+    void close();
 
 Review comment:
   @Override

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services