You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/05 02:35:45 UTC
[GitHub] [dubbo-go-pixiu] alchemy-lee opened a new pull request #268: fix application listener bug
alchemy-lee opened a new pull request #268:
URL: https://github.com/apache/dubbo-go-pixiu/pull/268
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
This PR removes the invocation of application listener temporarily. And fixes the type parameters in `proxy` sample.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #268: fix application listener bug
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #268:
URL: https://github.com/apache/dubbo-go-pixiu/pull/268#issuecomment-934009667
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#268](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8bcca76) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/bd2b5e4e0c2146ea79a2bda117873e538f98540b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd2b5e4) will **decrease** coverage by `0.45%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #268 +/- ##
===========================================
- Coverage 33.62% 33.16% -0.46%
===========================================
Files 56 56
Lines 3254 3241 -13
===========================================
- Hits 1094 1075 -19
- Misses 2048 2056 +8
+ Partials 112 110 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apter/dubboregistry/registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvcmVnaXN0cnkuZ28=) | `47.50% <ø> (+9.76%)` | :arrow_up: |
| [pkg/client/dubbo/option.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9vcHRpb24uZ28=) | `64.89% <ø> (ø)` | |
| [...oregistry/registry/zookeeper/interface\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvaW50ZXJmYWNlX2xpc3RlbmVyLmdv) | `10.00% <0.00%> (-22.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bd2b5e4...8bcca76](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #268: fix application listener bug
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #268:
URL: https://github.com/apache/dubbo-go-pixiu/pull/268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #268: fix application listener bug
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #268:
URL: https://github.com/apache/dubbo-go-pixiu/pull/268#issuecomment-934009667
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#268](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (824cf4f) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/2b00c319c59763842f6ef11830ed7cf2216feccc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2b00c31) will **decrease** coverage by `0.44%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #268 +/- ##
===========================================
- Coverage 33.59% 33.15% -0.45%
===========================================
Files 62 62
Lines 3334 3321 -13
===========================================
- Hits 1120 1101 -19
- Misses 2098 2106 +8
+ Partials 116 114 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apter/dubboregistry/registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvcmVnaXN0cnkuZ28=) | `47.50% <ø> (+9.76%)` | :arrow_up: |
| [pkg/client/dubbo/option.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9vcHRpb24uZ28=) | `64.89% <ø> (ø)` | |
| [...oregistry/registry/zookeeper/interface\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvaW50ZXJmYWNlX2xpc3RlbmVyLmdv) | `10.00% <0.00%> (-22.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2b00c31...824cf4f](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #268: fix application listener bug
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #268:
URL: https://github.com/apache/dubbo-go-pixiu/pull/268#issuecomment-934009667
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#268](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8bcca76) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/bd2b5e4e0c2146ea79a2bda117873e538f98540b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd2b5e4) will **decrease** coverage by `0.45%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #268 +/- ##
===========================================
- Coverage 33.62% 33.16% -0.46%
===========================================
Files 56 56
Lines 3254 3241 -13
===========================================
- Hits 1094 1075 -19
- Misses 2048 2056 +8
+ Partials 112 110 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apter/dubboregistry/registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvcmVnaXN0cnkuZ28=) | `47.50% <ø> (+9.76%)` | :arrow_up: |
| [pkg/client/dubbo/option.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9vcHRpb24uZ28=) | `64.89% <ø> (ø)` | |
| [...oregistry/registry/zookeeper/interface\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvaW50ZXJmYWNlX2xpc3RlbmVyLmdv) | `10.00% <0.00%> (-22.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bd2b5e4...8bcca76](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #268: fix application listener bug
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #268:
URL: https://github.com/apache/dubbo-go-pixiu/pull/268#issuecomment-934009667
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#268](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8bcca76) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/bd2b5e4e0c2146ea79a2bda117873e538f98540b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd2b5e4) will **decrease** coverage by `0.45%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #268 +/- ##
===========================================
- Coverage 33.62% 33.16% -0.46%
===========================================
Files 56 56
Lines 3254 3241 -13
===========================================
- Hits 1094 1075 -19
- Misses 2048 2056 +8
+ Partials 112 110 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apter/dubboregistry/registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvcmVnaXN0cnkuZ28=) | `47.50% <ø> (+9.76%)` | :arrow_up: |
| [pkg/client/dubbo/option.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9vcHRpb24uZ28=) | `64.89% <ø> (ø)` | |
| [...oregistry/registry/zookeeper/interface\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvaW50ZXJmYWNlX2xpc3RlbmVyLmdv) | `10.00% <0.00%> (-22.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bd2b5e4...8bcca76](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/268?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org