You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/06 15:14:44 UTC

[GitHub] [arrow] aocsa commented on pull request #11017: ARROW-13542: [C++][Compute][Dataset] Add dataset::WriteNode for writing rows from an ExecPlan to disk

aocsa commented on pull request #11017:
URL: https://github.com/apache/arrow/pull/11017#issuecomment-936473091


   LGTM too me too. I reviewed the code and there are some common patterns to handle signals, input_counter and future `finished` vars that Is common in different ExecNodes as sames as MapExecNode I think should documented somewhere, specially to the newbies that don't want to mess with race condition.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org