You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/12 10:57:47 UTC
[GitHub] [iotdb] MinaQin opened a new issue, #5879: This class overrides "equals()" and should therefore also override "hashCode()".
MinaQin opened a new issue, #5879:
URL: https://github.com/apache/iotdb/issues/5879
Code Path:confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/auth/AuthorReq.java
<img width="877" alt="image" src="https://user-images.githubusercontent.com/55030443/168055618-b1b033cf-5bcb-44b6-bbc6-352252a076c2.png">
According to the Java Language Specification, there is a contract between equals(Object) and hashCode():
If two objects are equal according to the equals(Object) method, then calling the hashCode method on each of the two objects must produce the same integer result.
It is not required that if two objects are unequal according to the equals(java.lang.Object) method, then calling the hashCode method on each of the two objects must produce distinct integer results.
However, the programmer should be aware that producing distinct integer results for unequal objects may improve the performance of hashtables.
In order to comply with this contract, those methods should be either both inherited, or both overridden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin closed issue #5879: This class overrides "equals()" and should therefore also override "hashCode()".
Posted by GitBox <gi...@apache.org>.
qiaojialin closed issue #5879: This class overrides "equals()" and should therefore also override "hashCode()".
URL: https://github.com/apache/iotdb/issues/5879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] chakkk309 commented on issue #5879: This class overrides "equals()" and should therefore also override "hashCode()".
Posted by GitBox <gi...@apache.org>.
chakkk309 commented on issue #5879:
URL: https://github.com/apache/iotdb/issues/5879#issuecomment-1140470802
Hi, I want to try it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org