[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3681: Add Python TO client support for updating a user by ID

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #3681: Add Python TO client support for updating a user by ID
URL: https://github.com/apache/trafficcontrol/pull/3681#discussion_r294355318
 
 

 ##########
 File path: traffic_control/clients/python/trafficops/tosession.py
 ##########
 @@ -2405,6 +2405,17 @@ def create_user(self, data=None):
 		:raises: Union[LoginError, OperationError]
 		"""
 
+	@api_request(u'put', u'users/{user_id:d}', (u'1.1', u'1.2', u'1.3',))
 
 Review comment:
   done
   
   Although, it appears to still be requesting 1.3. Off-hand, I don't know what the underlying mechanism is for which API version to request -- maybe the latest version common to all methods? Ideally we should only have to specify the lowest minor version that the method supports, but the client would make all API requests at the latest minor version (1.4) where possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services